Attention is currently required from: Hung-Te Lin, Yu-Ping Wu, cong yang.
Yidi Lin has posted comments on this change by Rui Zhou. ( https://review.coreboot.org/c/coreboot/+/83287?usp=email )
Change subject: mb/google/geralt: support TAS2563 audio amp ......................................................................
Patch Set 5:
(1 comment)
File src/mainboard/google/geralt/mainboard.c:
https://review.coreboot.org/c/coreboot/+/83287/comment/0814bf37_f6fe2117?usp... : PS5, Line 38: if (fw_config_probe(FW_CONFIG(AUDIO_AMP, AMP_MAX98390))) { : printk(BIOS_DEBUG, "Configure MAX98390 audio\n"); : : mtk_i2c_bus_init(I2C0, I2C_SPEED_FAST); : configure_i2s(); : } else if (fw_config_probe(FW_CONFIG(AUDIO_AMP, AMP_TAS2563))) { : printk(BIOS_DEBUG, "Configure TAS2563 audio\n"); : mtk_i2c_bus_init(I2C0, I2C_SPEED_FAST); : configure_i2s(); : } Can you check if the FW log shows something like this ? ``` fw_config match found: xxxxxxxx ```
If so, then we can just write ``` if (fw_config_probe(FW_CONFIG(AUDIO_AMP, AMP_MAX98390)) || fw_config_probe(FW_CONFIG(AUDIO_AMP, AMP_TAS2563))) { ... } ```