[XL] Change in coreboot[main]: soc/mediatek/mt8196: Add PMIF and PMIC driver support - coreboot-gerrit

5 Dec 2024


      Attention is currently required from: Hung-Te Lin, Jarried Lin, Paul Menzel.
Yu-Ping Wu has posted comments on this change by Jarried Lin. ( https://review.coreboot.org/c/coreboot/+/85126?usp=email )
Change subject: soc/mediatek/mt8196: Add PMIF and PMIC driver support
......................................................................
Patch Set 14:
(1 comment)
File src/soc/mediatek/mt8196/include/soc/pmif.h:
https://review.coreboot.org/c/coreboot/+/85126/comment/f7bc1659_bd206597?usp... :
PS14, Line 114: OFFSET4
Please use a meaningful name. What's in offset4?
-- 
To view, visit https://review.coreboot.org/c/coreboot/+/85126?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email

Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I232015f45735ee5278b09d0352410617a1565177
Gerrit-Change-Number: 85126
Gerrit-PatchSet: 14
Gerrit-Owner: Jarried Lin jarried.lin@mediatek.com
Gerrit-Reviewer: Hope Wang hope.wang@mediatek.corp-partner.google.com
Gerrit-Reviewer: Hung-Te Lin hungte@chromium.org
Gerrit-Reviewer: Yu-Ping Wu yupingso@google.com
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Paul Menzel paulepanter@mailbox.org
Gerrit-CC: Yidi Lin yidilin@google.com
Gerrit-Attention: Hung-Te Lin hungte@chromium.org
Gerrit-Attention: Paul Menzel paulepanter@mailbox.org
Gerrit-Attention: Jarried Lin jarried.lin@mediatek.com
Gerrit-Comment-Date: Thu, 05 Dec 2024 07:13:56 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No