Attention is currently required from: Martin Roth, Selma Bensaid, Subrata Banik, Bernardo Perez Priego, Usha P, Andrey Petrov, Patrick Rudolph. Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/51105 )
Change subject: drivers/intel/fsp2_0/memory_init: Add saving memory info API ......................................................................
Patch Set 2:
(2 comments)
File src/drivers/intel/fsp2_0/hob_memory_info.c:
PS2: In my opinion, this file belongs in soc/intel/common/block/memory. Reason is the same as I mentioned before - this is a platform specific implementation and not something that the FSP spec covers. Hence, this must not be added to fsp driver here.
https://review.coreboot.org/c/coreboot/+/51105/comment/1e7298f2_0ddd84d3 PS2, Line 16: #ifndef CHANNEL_NOT_PRESENT : #define CHANNEL_NOT_PRESENT 0 // There is no channel present on the controller. : #endif : #ifndef CHANNEL_DISABLED : #define CHANNEL_DISABLED 1 // There is a channel present but it is disabled. : #endif : #ifndef CHANNEL_PRESENT : #define CHANNEL_PRESENT 2 // There is a channel present and it is enabled. : #endif These should come from the FSP headers and not defined in coreboot. I think once you move this file to soc/intel/common/block/memory, you should update the file to include a soc header which pulls in all the required FSP provided header files as well as provide the definition of FSP_SMBIOS_MEMORY_INFO_GUID on a per platform level.