[L] Change in coreboot[master]: RFC: util/sconfig: Add include keyword - coreboot-gerrit

25 Apr 2023


      Attention is currently required from: Martin L Roth, Jon Murphy, Arthur Heymans, Angel Pons, Tim Van Patten, Karthik Ramasubramanian, Felix Held.
Raul Rangel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74736 )
Change subject: RFC: util/sconfig: Add include keyword
......................................................................
Patch Set 1:
(1 comment)
Commit Message:
https://review.coreboot.org/c/coreboot/+/74736/comment/dcb710a6_529e7bdc 
PS1, Line 9: Include
...
...
Instead of adding a new keyword, how about we just make sconfig check for a `chip. […]
That also requires a rule to force static.o to rebuild if file.h changes.
-- 
To view, visit https://review.coreboot.org/c/coreboot/+/74736
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I34893a703cc4f588dda3736e858429bf765059e6
Gerrit-Change-Number: 74736
Gerrit-PatchSet: 1
Gerrit-Owner: Karthik Ramasubramanian kramasub@google.com
Gerrit-Reviewer: Angel Pons angel.pons@9elements.com
Gerrit-Reviewer: Arthur Heymans arthur@aheymans.xyz
Gerrit-Reviewer: Felix Held felix-coreboot@felixheld.de
Gerrit-Reviewer: Jon Murphy jpmurphy@google.com
Gerrit-Reviewer: Martin L Roth gaumless@gmail.com
Gerrit-Reviewer: Raul Rangel rrangel@chromium.org
Gerrit-Reviewer: Tim Van Patten timvp@google.com
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-Attention: Martin L Roth gaumless@gmail.com
Gerrit-Attention: Jon Murphy jpmurphy@google.com
Gerrit-Attention: Arthur Heymans arthur@aheymans.xyz
Gerrit-Attention: Angel Pons angel.pons@9elements.com
Gerrit-Attention: Tim Van Patten timvp@google.com
Gerrit-Attention: Karthik Ramasubramanian kramasub@google.com
Gerrit-Attention: Felix Held felix-coreboot@felixheld.de
Gerrit-Comment-Date: Tue, 25 Apr 2023 19:52:07 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Raul Rangel rrangel@chromium.org
Comment-In-Reply-To: Arthur Heymans arthur@aheymans.xyz
Gerrit-MessageType: comment