Attention is currently required from: Angel Pons, Jeff Daly, Lance Zhao, Matt DeVillier, Nico Huber, Sean Rhodes, Tim Wawrzynczak, Vanessa Eusebio.
Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/75729?usp=email )
Change subject: UNTESTED acpi: Add ECAM region below PNP0C02 device in SSDT
......................................................................
Patch Set 2:
(2 comments)
File src/acpi/acpi.c:
https://review.coreboot.org/c/coreboot/+/75729/comment/3435b5ea_ffebb96d :
PS2, Line 587: struct device *dev = dev_find_path(NULL, DEVICE_PATH_DOMAIN);
: assert(dev != NULL);
We could also export domain devices to `build/static_devices.h`.
OTOH, filtering the right device in the loop device should do too.
On some upcoming, not yet upstream AMD platform I use domain numbers to match an ID on the data fabric. That would make static_devices.h harder to use.
https://review.coreboot.org/c/coreboot/+/75729/comment/456f085a_acfb67c4 :
PS2, Line 594: 1
Shouldn't this be unique (I'm not sure about the scope)? i.e. not the same
as in the static `.asl` files.
I tried to find a device name not found in DSDT and just set _UID to 1 without a particular reason (probably copied from existing DSDT)
--
To view, visit
https://review.coreboot.org/c/coreboot/+/75729?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I852e393726a1b086cf582f4d2d707e7cde05cbf4
Gerrit-Change-Number: 75729
Gerrit-PatchSet: 2
Gerrit-Owner: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Jeff Daly
jeffd@silicom-usa.com
Gerrit-Reviewer: Lance Zhao
lance.zhao@gmail.com
Gerrit-Reviewer: Matt DeVillier
matt.devillier@gmail.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Sean Rhodes
sean@starlabs.systems
Gerrit-Reviewer: Tim Wawrzynczak
inforichland@gmail.com
Gerrit-Reviewer: Vanessa Eusebio
vanessa.f.eusebio@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Lance Zhao
lance.zhao@gmail.com
Gerrit-Attention: Nico Huber
nico.h@gmx.de
Gerrit-Attention: Sean Rhodes
sean@starlabs.systems
Gerrit-Attention: Jeff Daly
jeffd@silicom-usa.com
Gerrit-Attention: Matt DeVillier
matt.devillier@gmail.com
Gerrit-Attention: Tim Wawrzynczak
inforichland@gmail.com
Gerrit-Attention: Vanessa Eusebio
vanessa.f.eusebio@intel.com
Gerrit-Attention: Angel Pons
th3fanbus@gmail.com
Gerrit-Comment-Date: Tue, 13 Jun 2023 07:17:48 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Nico Huber
nico.h@gmx.de
Gerrit-MessageType: comment