Felix Held has submitted this change. ( https://review.coreboot.org/c/coreboot/+/81921?usp=email )
Change subject: mb/asus/p8z77-m[_pro]: Correct PCH GPIO config ......................................................................
mb/asus/p8z77-m[_pro]: Correct PCH GPIO config
According to a boardview, GPIO27 is connected to the front panel power LED, and should be output.
It will be made to blink before entering S3 suspend in a follow-up.
Change-Id: I7e47f63999e8c0bfbd37e3273d33c00bc035bcbb Signed-off-by: Keith Hui buurin@gmail.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/81921 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Patrick Rudolph patrick.rudolph@9elements.com --- M src/mainboard/asus/p8x7x-series/variants/p8z77-m/gpio.c M src/mainboard/asus/p8x7x-series/variants/p8z77-m_pro/gpio.c 2 files changed, 4 insertions(+), 2 deletions(-)
Approvals: build bot (Jenkins): Verified Patrick Rudolph: Looks good to me, approved
diff --git a/src/mainboard/asus/p8x7x-series/variants/p8z77-m/gpio.c b/src/mainboard/asus/p8x7x-series/variants/p8z77-m/gpio.c index c1012e3..2c71c6a 100644 --- a/src/mainboard/asus/p8x7x-series/variants/p8z77-m/gpio.c +++ b/src/mainboard/asus/p8x7x-series/variants/p8z77-m/gpio.c @@ -50,7 +50,7 @@ .gpio17 = GPIO_DIR_INPUT, .gpio21 = GPIO_DIR_INPUT, .gpio24 = GPIO_DIR_OUTPUT, - .gpio27 = GPIO_DIR_INPUT, + .gpio27 = GPIO_DIR_OUTPUT, .gpio28 = GPIO_DIR_OUTPUT, .gpio29 = GPIO_DIR_OUTPUT, .gpio31 = GPIO_DIR_OUTPUT, @@ -61,6 +61,7 @@ .gpio12 = GPIO_LEVEL_LOW, .gpio15 = GPIO_LEVEL_LOW, .gpio24 = GPIO_LEVEL_LOW, + .gpio27 = GPIO_LEVEL_HIGH, .gpio28 = GPIO_LEVEL_LOW, .gpio29 = GPIO_LEVEL_HIGH, .gpio31 = GPIO_LEVEL_HIGH, diff --git a/src/mainboard/asus/p8x7x-series/variants/p8z77-m_pro/gpio.c b/src/mainboard/asus/p8x7x-series/variants/p8z77-m_pro/gpio.c index 2455bd6..da76f78 100644 --- a/src/mainboard/asus/p8x7x-series/variants/p8z77-m_pro/gpio.c +++ b/src/mainboard/asus/p8x7x-series/variants/p8z77-m_pro/gpio.c @@ -50,7 +50,7 @@ .gpio17 = GPIO_DIR_INPUT, .gpio21 = GPIO_DIR_INPUT, .gpio24 = GPIO_DIR_OUTPUT, - .gpio27 = GPIO_DIR_INPUT, + .gpio27 = GPIO_DIR_OUTPUT, .gpio28 = GPIO_DIR_OUTPUT, .gpio29 = GPIO_DIR_OUTPUT, .gpio31 = GPIO_DIR_OUTPUT, @@ -61,6 +61,7 @@ .gpio12 = GPIO_LEVEL_LOW, .gpio15 = GPIO_LEVEL_LOW, .gpio24 = GPIO_LEVEL_LOW, + .gpio27 = GPIO_LEVEL_HIGH, .gpio28 = GPIO_LEVEL_LOW, .gpio29 = GPIO_LEVEL_HIGH, .gpio31 = GPIO_LEVEL_HIGH,