Attention is currently required from: Hung-Te Lin, Knox Chiou, Yang Wu, Yu-Ping Wu.
Yidi Lin has posted comments on this change by Yang Wu. ( https://review.coreboot.org/c/coreboot/+/84342?usp=email )
Change subject: mb/google/corsola: Make compatible with MT8186T by modifing skuid
......................................................................
Patch Set 2:
(1 comment)
File src/mainboard/google/corsola/boardid.c:
https://review.coreboot.org/c/coreboot/+/84342/comment/97b5ed90_06d16e1d?usp... :
PS2, Line 132: BOARD_GOOGLE_STEELIX
Both on `Steelix`(mt8186) and `Voltorb/Squirtle`(mt8186t), our factory is already using 0x7fffffff a […]
IIUIC
Originally, Steelix(mt8186) and Voltorb/Squirtle(mt8186t) are differentiated by the compatible string `<board>`-sku`<id>`. Since their board names are different, they can use the some unprovisioned SKU ID(0x7FFF_FFFF) safely to choose different DTBs. Now Steelix needs a new SKU ID to differentiate Steelix(mt8186) and Steelix(mt8186t).
Is that what you mean ?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/84342?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I91306d3abd508e104851916882fb36a4fd302036
Gerrit-Change-Number: 84342
Gerrit-PatchSet: 2
Gerrit-Owner: Yang Wu
wuyang5@huaqin.corp-partner.google.com
Gerrit-Reviewer: Hung-Te Lin
hungte@chromium.org
Gerrit-Reviewer: Knox Chiou
knoxchiou@google.com
Gerrit-Reviewer: Xinxiong Xu
xuxinxiong@huaqin.corp-partner.google.com
Gerrit-Reviewer: Yidi Lin
yidilin@google.com
Gerrit-Reviewer: Yu-Ping Wu
yupingso@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Hung-Te Lin
hungte@chromium.org
Gerrit-Attention: Knox Chiou
knoxchiou@google.com
Gerrit-Attention: Yang Wu
wuyang5@huaqin.corp-partner.google.com
Gerrit-Attention: Yu-Ping Wu
yupingso@google.com
Gerrit-Comment-Date: Fri, 13 Sep 2024 13:30:33 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Yang Wu
wuyang5@huaqin.corp-partner.google.com
Comment-In-Reply-To: Yu-Ping Wu
yupingso@google.com