Change in coreboot[master]: src: don't select GENERATE_MP_TABLE if DRIVERS_GENERIC_IOAPIC is set
Felix Held has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/42581 )
Change subject: src: don't select GENERATE_MP_TABLE if DRIVERS_GENERIC_IOAPIC is set ......................................................................
src: don't select GENERATE_MP_TABLE if DRIVERS_GENERIC_IOAPIC is set
None of the boards selecting DRIVERS_GENERIC_IOAPIC has a non-empty mptable.c, so don't select GENERATE_MP_TABLE if DRIVERS_GENERIC_IOAPIC is selected.
Change-Id: I785874df604e52feb06a2e67a29de1ffead29bfc Signed-off-by: Felix Held felix-coreboot@felixheld.de --- M src/Kconfig 1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/81/42581/1
diff --git a/src/Kconfig b/src/Kconfig index 1b49e2b..e1b37b3 100644 --- a/src/Kconfig +++ b/src/Kconfig @@ -669,7 +669,7 @@ config GENERATE_MP_TABLE prompt "Generate an MP table" if HAVE_MP_TABLE || DRIVERS_GENERIC_IOAPIC bool - default HAVE_MP_TABLE || DRIVERS_GENERIC_IOAPIC + default HAVE_MP_TABLE help Generate an MP table (conforming to the Intel MultiProcessor specification 1.4) for this board.
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42581 )
Change subject: src: don't select GENERATE_MP_TABLE if DRIVERS_GENERIC_IOAPIC is set ......................................................................
Patch Set 1: Code-Review+1
(1 comment)
https://review.coreboot.org/c/coreboot/+/42581/1/src/Kconfig File src/Kconfig:
https://review.coreboot.org/c/coreboot/+/42581/1/src/Kconfig@670 PS1, Line 670: DRIVERS_GENERIC_IOAPIC Um, missed this one
Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42581 )
Change subject: src: don't select GENERATE_MP_TABLE if DRIVERS_GENERIC_IOAPIC is set ......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/c/coreboot/+/42581/1/src/Kconfig File src/Kconfig:
https://review.coreboot.org/c/coreboot/+/42581/1/src/Kconfig@670 PS1, Line 670: DRIVERS_GENERIC_IOAPIC
Um, missed this one
Wasn't sure about that one
Hello build bot (Jenkins), Angel Pons,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/42581
to look at the new patch set (#2).
Change subject: src: don't select GENERATE_MP_TABLE if DRIVERS_GENERIC_IOAPIC is set ......................................................................
src: don't select GENERATE_MP_TABLE if DRIVERS_GENERIC_IOAPIC is set
None of the boards selecting DRIVERS_GENERIC_IOAPIC has a non-empty mptable.c, so don't select GENERATE_MP_TABLE if DRIVERS_GENERIC_IOAPIC is selected.
Change-Id: I785874df604e52feb06a2e67a29de1ffead29bfc Signed-off-by: Felix Held felix-coreboot@felixheld.de --- M src/Kconfig 1 file changed, 2 insertions(+), 2 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/81/42581/2
Felix Held has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/42581 )
Change subject: src: don't select GENERATE_MP_TABLE if DRIVERS_GENERIC_IOAPIC is set ......................................................................
Abandoned
this changes behaviour due to a weak definition of write_smp_table()
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42581 )
Change subject: src: don't select GENERATE_MP_TABLE if DRIVERS_GENERIC_IOAPIC is set ......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/c/coreboot/+/42581/1/src/Kconfig File src/Kconfig:
https://review.coreboot.org/c/coreboot/+/42581/1/src/Kconfig@670 PS1, Line 670: DRIVERS_GENERIC_IOAPIC
Wasn't sure about that one
Uh, I'd just clean up the whole option:
config GENERATE_MP_TABLE bool "Generate an MP table" default y depends on HAVE_MP_TABLE help Generate an MP table (conforming to the Intel MultiProcessor specification 1.4) for this board.
If unsure, say Y.
-
Angel Pons (Code Review) -
Felix Held (Code Review)