Attention is currently required from: Lance Zhao, Furquan Shaikh, Martin Roth, Tim Wawrzynczak, Duncan Laurie, Aamir Bohra, Srinidhi N Kaushik.
Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/49406 )
Change subject: acpi: Add function for generating a static PCI routing table
......................................................................
Patch Set 2:
(1 comment)
File src/acpi/acpigen_pci.c:
https://review.coreboot.org/c/coreboot/+/49406/comment/1d1fc690_5930d52e
PS2, Line 47: if (entries[i].pin == PCI_INT_B)
: acpigen_write_dword(10);
: else
: acpigen_write_dword(11);
That is the usual configuration platforms in soc/intel/* use. It is configurable and therefore not generally true.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/49406
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I87c76b30b14fab175301d10cb5e5bea69769c8cf
Gerrit-Change-Number: 49406
Gerrit-PatchSet: 2
Gerrit-Owner: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: Aamir Bohra
aamir.bohra@intel.com
Gerrit-Reviewer: Duncan Laurie
dlaurie@chromium.org
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Lance Zhao
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Srinidhi N Kaushik
srinidhi.n.kaushik@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Attention: Lance Zhao
Gerrit-Attention: Furquan Shaikh
furquan@google.com
Gerrit-Attention: Martin Roth
martinroth@google.com
Gerrit-Attention: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Attention: Duncan Laurie
dlaurie@chromium.org
Gerrit-Attention: Aamir Bohra
aamir.bohra@intel.com
Gerrit-Attention: Srinidhi N Kaushik
srinidhi.n.kaushik@intel.com
Gerrit-Comment-Date: Sat, 16 Jan 2021 20:33:50 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment