Attention is currently required from: Subrata Banik, Ravishankar Sarawadi, Angel Pons, Nick Vaccaro, Tim Wawrzynczak.
Wonkyu Kim has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/63471 )
Change subject: soc/intel/cmn/{block, pch}: Migrate GPMR driver
......................................................................
Patch Set 13:
(2 comments)
File src/soc/intel/common/block/lpc/lpc_lib.c:
https://review.coreboot.org/c/coreboot/+/63471/comment/602881cb_7b23f0bf
PS13, Line 29: gpmr_write32
This write was changed from 16 bits to 32 bits, is it OK?
Register offset is 4 byte aligned. So it's ok to use 32bit access.
https://review.coreboot.org/c/coreboot/+/63471/comment/cdbc0535_2baa7610
PS13, Line 47: gpmr_write32
Ditto.
Register offset is 4 byte aligned. So it's ok to use 32bit access.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/63471
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I00ac667e8d3f2ccefd8d51a8150a989fc8e5c7e2
Gerrit-Change-Number: 63471
Gerrit-PatchSet: 13
Gerrit-Owner: Wonkyu Kim
wonkyu.kim@intel.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Eric Lai
eric_lai@quanta.corp-partner.google.com
Gerrit-Reviewer: Nick Vaccaro
nvaccaro@google.com
Gerrit-Reviewer: Ravishankar Sarawadi
ravishankar.sarawadi@intel.com
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Subrata Banik
subratabanik@google.com
Gerrit-Attention: Ravishankar Sarawadi
ravishankar.sarawadi@intel.com
Gerrit-Attention: Angel Pons
th3fanbus@gmail.com
Gerrit-Attention: Nick Vaccaro
nvaccaro@google.com
Gerrit-Attention: Tim Wawrzynczak
twawrzynczak@google.com
Gerrit-Comment-Date: Fri, 15 Apr 2022 15:58:00 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Angel Pons
th3fanbus@gmail.com
Gerrit-MessageType: comment