Attention is currently required from: Arthur Heymans, Jakub Czapiga, Martin L Roth.
Felix Singer has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/80063?usp=email )
Change subject: Makefiles: Rename top-level Makefiles from .inc to .mak
......................................................................
Patch Set 2:
(1 comment)
Commit Message:
https://review.coreboot.org/c/coreboot/+/80063/comment/c2ce6103_351d8da0 :
PS2, Line 10: This means that editors don't recognize the files, and don't
: open them with highlighting and any other specific editor functionality.
:
I didn't try emacs. my editors recognize the .mak extension by default. […]
I also prefer .mk to be honest, but I don't have a strong opinion about it. .mak is fine to me. I will see if I can come up with something and adjust the patch series.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/80063?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Idaf69c6871d0bc1ee5e2e53157b8631c55eb3db9
Gerrit-Change-Number: 80063
Gerrit-PatchSet: 2
Gerrit-Owner: Martin L Roth
gaumless@gmail.com
Gerrit-Reviewer: Felix Singer
service+coreboot-gerrit@felixsinger.de
Gerrit-Reviewer: Jakub Czapiga
czapiga@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Attention: Martin L Roth
gaumless@gmail.com
Gerrit-Attention: Jakub Czapiga
czapiga@google.com
Gerrit-Attention: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Comment-Date: Sat, 20 Jan 2024 22:14:06 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Felix Singer
service+coreboot-gerrit@felixsinger.de
Comment-In-Reply-To: Martin L Roth
gaumless@gmail.com
Comment-In-Reply-To: Arthur Heymans
arthur@aheymans.xyz
Gerrit-MessageType: comment