Attention is currently required from: Hung-Te Lin, Jarried Lin, Paul Menzel.
Yu-Ping Wu has posted comments on this change by Jarried Lin. ( https://review.coreboot.org/c/coreboot/+/85124?usp=email )
Change subject: soc/mediatek/mt8196: Reserve DRAM buffers for HW TX TRACKING
......................................................................
Patch Set 18:
(1 comment)
File src/soc/mediatek/mt8196/dramc_info.c:
https://review.coreboot.org/c/coreboot/+/85124/comment/a9cb6937_63f0bd0c?usp... :
PS18, Line 17: uint64_t rank_size_sum = 0;
size_t?
The total density may exceed the limit of `size_t`. `mem_chip_info_total_density_bytes` in mem_chip_info.h also returns `uint64_t` instead of `size_t`.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/85124?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I042a74c7fbdc0d3dc19dd6bfd2bf021fe1c2b5fc
Gerrit-Change-Number: 85124
Gerrit-PatchSet: 18
Gerrit-Owner: Jarried Lin
jarried.lin@mediatek.com
Gerrit-Reviewer: Hung-Te Lin
hungte@chromium.org
Gerrit-Reviewer: Yidi Lin
yidilin@google.com
Gerrit-Reviewer: Yu-Ping Wu
yupingso@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Crystal Guo
crystal.guo@mediatek.corp-partner.google.com
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Hung-Te Lin
hungte@chromium.org
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Jarried Lin
jarried.lin@mediatek.com
Gerrit-Comment-Date: Tue, 26 Nov 2024 08:06:01 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Paul Menzel
paulepanter@mailbox.org