Attention is currently required from: Shelley Chen, Ravi kumar.
Sudheer Amrabadi has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/58545 )
Change subject: sc7280: Add Modem region to avoid modem cleanup in Secboot reboot.
......................................................................
Patch Set 20:
(3 comments)
Patchset:
PS20:
stashed unwanted includes statements
File src/soc/qualcomm/sc7280/carve_out.c:
https://review.coreboot.org/c/coreboot/+/58545/comment/dca309ce_56c2083e
PS19, Line 7: /
What do you need this #include console/console. […]
Ack
File src/soc/qualcomm/sc7280/soc.c:
https://review.coreboot.org/c/coreboot/+/58545/comment/377e17fd_bfe9812f
PS19, Line 9: #include <console/console.h>
What do you need this #include console/console. […]
Ack
--
To view, visit
https://review.coreboot.org/c/coreboot/+/58545
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I56bfb210606b08893ff71dd1b6679f1ec102ec95
Gerrit-Change-Number: 58545
Gerrit-PatchSet: 20
Gerrit-Owner: Ravi kumar
rbokka@codeaurora.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-CC: Shelley Chen
shchen@google.com
Gerrit-CC: Sudheer Amrabadi
samrabad@codeaurora.org
Gerrit-CC: mturney mturney
quic_mturney@quicinc.com
Gerrit-Attention: Shelley Chen
shchen@google.com
Gerrit-Attention: Ravi kumar
rbokka@codeaurora.org
Gerrit-Comment-Date: Thu, 27 Jan 2022 17:48:32 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Shelley Chen
shchen@google.com
Gerrit-MessageType: comment