Attention is currently required from: Felix Singer, Furquan Shaikh, Mariusz Szafrański, Paul Menzel, Subrata Banik, Angel Pons, Michael Niewöhner, Patrick Rudolph, Lance Zhao, Tim Wawrzynczak, Suresh Bellampalli, Vanessa Eusebio, Michal Motyl.
Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/57934 )
Change subject: soc/intel/{common,skl}: set ACPI_FADT_PLATFORM_CLOCK based on Kconfig
......................................................................
Patch Set 22: Code-Review+2
(1 comment)
Commit Message:
https://review.coreboot.org/c/coreboot/+/57934/comment/895f557a_6d802f6f
PS21, Line 14:
Please mention the platforms that change behavior, e.g. APL/GLK
because for those USE_PM_ACPI_TIMER will always be false. Maybe
even the boards that default to !USE_PM_ACPI_TIMER.
DNV does not change afaics, as its soc_fill_fadt() overwrites
what acpi_fill_fadt() does, I guess.
Do we know the situation on Xeon-SP? If it doesn't select
PM_ACPI_TIMER_OPTIONAL, it will change behavior too.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/57934
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Id2e5d69b5515c21e6ce922dab2cb88b494c65ebe
Gerrit-Change-Number: 57934
Gerrit-PatchSet: 22
Gerrit-Owner: Michael Niewöhner
foss@mniewoehner.de
Gerrit-Reviewer: Felix Singer
felixsinger@posteo.net
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Lance Zhao
Gerrit-Reviewer: Mariusz Szafrański
mariuszx.szafranski@intel.com
Gerrit-Reviewer: Michael Niewöhner
foss@mniewoehner.de
Gerrit-Reviewer: Michal Motyl
michalx.motyl@intel.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Paul Menzel
paulepanter@mailbox.org
Gerrit-Reviewer: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: Suresh Bellampalli
suresh.bellampalli@intel.com
Gerrit-Reviewer: Tim Wawrzynczak
inforichland@gmail.com
Gerrit-Reviewer: Vanessa Eusebio
vanessa.f.eusebio@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Felix Singer
felixsinger@posteo.net
Gerrit-Attention: Furquan Shaikh
furquan@google.com
Gerrit-Attention: Mariusz Szafrański
mariuszx.szafranski@intel.com
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Subrata Banik
subrata.banik@intel.com
Gerrit-Attention: Angel Pons
th3fanbus@gmail.com
Gerrit-Attention: Michael Niewöhner
foss@mniewoehner.de
Gerrit-Attention: Patrick Rudolph
siro@das-labor.org
Gerrit-Attention: Lance Zhao
Gerrit-Attention: Tim Wawrzynczak
inforichland@gmail.com
Gerrit-Attention: Suresh Bellampalli
suresh.bellampalli@intel.com
Gerrit-Attention: Vanessa Eusebio
vanessa.f.eusebio@intel.com
Gerrit-Attention: Michal Motyl
michalx.motyl@intel.com
Gerrit-Comment-Date: Sat, 02 Oct 2021 14:56:35 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment