Attention is currently required from: Hung-Te Lin. build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/60317 )
Change subject: soc/mediatek/mt8186: Add devapc basic drivers ......................................................................
Patch Set 1:
(11 comments)
File src/soc/mediatek/mt8186/devapc.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-136071): https://review.coreboot.org/c/coreboot/+/60317/comment/5665cbb0_fdd9c720 PS1, Line 23: DAPC_INFRA_AO_SYS0_ATTR("INFRA_AO_SLEEP_CONTROLER", 'CONTROLER' may be misspelled - perhaps 'CONTROLLER'?
File src/soc/mediatek/mt8186/include/soc/devapc.h:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-136071): https://review.coreboot.org/c/coreboot/+/60317/comment/c312d7e8_9e38d321 PS1, Line 66: #define DAPC_PERM_ATTR_4(DEV_NAME, PERM_ATTR0, PERM_ATTR1, \ Macros with complex values should be enclosed in parentheses
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-136071): https://review.coreboot.org/c/coreboot/+/60317/comment/1c785f23_08068d7b PS1, Line 71: #define DAPC_PERM_ATTR_8(DEV_NAME, PERM_ATTR0, PERM_ATTR1, \ Macros with complex values should be enclosed in parentheses
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-136071): https://review.coreboot.org/c/coreboot/+/60317/comment/30be648d_f7ffa018 PS1, Line 79: #define DAPC_PERM_ATTR_16(DEV_NAME, PERM_ATTR0, PERM_ATTR1, \ Macros with complex values should be enclosed in parentheses
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-136071): https://review.coreboot.org/c/coreboot/+/60317/comment/f84a110c_dc8e20ea PS1, Line 93: #define FORBIDDEN3 FORBIDDEN, FORBIDDEN, FORBIDDEN Macros with complex values should be enclosed in parentheses
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-136071): https://review.coreboot.org/c/coreboot/+/60317/comment/ee86643c_90beb1e4 PS1, Line 94: #define FORBIDDEN4 FORBIDDEN3, FORBIDDEN Macros with complex values should be enclosed in parentheses
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-136071): https://review.coreboot.org/c/coreboot/+/60317/comment/9a6e83ad_b5649808 PS1, Line 95: #define FORBIDDEN5 FORBIDDEN4, FORBIDDEN Macros with complex values should be enclosed in parentheses
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-136071): https://review.coreboot.org/c/coreboot/+/60317/comment/b65ef48e_bab06c9d PS1, Line 96: #define FORBIDDEN6 FORBIDDEN5, FORBIDDEN Macros with complex values should be enclosed in parentheses
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-136071): https://review.coreboot.org/c/coreboot/+/60317/comment/167d48f4_68dc0df9 PS1, Line 97: #define FORBIDDEN7 FORBIDDEN6, FORBIDDEN Macros with complex values should be enclosed in parentheses
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-136071): https://review.coreboot.org/c/coreboot/+/60317/comment/253d74d0_0e2e0633 PS1, Line 99: #define NO_PROTECTION4 NO_PROTECTION, NO_PROTECTION, NO_PROTECTION, NO_PROTECTION Macros with complex values should be enclosed in parentheses
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-136071): https://review.coreboot.org/c/coreboot/+/60317/comment/b56e7318_0a80b2c2 PS1, Line 123: DEFINE_BIT(SCP_SSPM_SEC,21) space required after that ',' (ctx:VxV)
-
build bot (Jenkins) (Code Review)