Patrick Rudolph has uploaded this change for review. ( https://review.coreboot.org/c/em100/+/36051 )
Change subject: Fix whitespace error ......................................................................
Fix whitespace error
Signed-off-by: Patrick Rudolph patrick.rudolph@9elements.com Change-Id: I5b2492668b1b41afb4c32b24cbf9554783767311 --- M em100.c 1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/em100 refs/changes/51/36051/1
diff --git a/em100.c b/em100.c index a20dc7d..6a348d3 100644 --- a/em100.c +++ b/em100.c @@ -642,7 +642,7 @@ " -c|--set CHIP: select chip emulation\n" " -d|--download FILE: download FILE into EM100pro\n" " -a|--start address: only works with -d (E.g. -d file.bin -a 0x300000)\n" - " -u|--upload FILE: upload from EM100pro into FILE\n" + " -u|--upload FILE: upload from EM100pro into FILE\n" " -r|--start: em100 shall run\n" " -s|--stop: em100 shall stop\n" " -v|--verify: verify EM100 content matches the file\n"
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/em100/+/36051 )
Change subject: Fix whitespace error ......................................................................
Patch Set 1: Code-Review+1
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/em100/+/36051 )
Change subject: Fix whitespace error ......................................................................
Patch Set 1: Code-Review+2
I wonder why it doesn't build
Stefan Reinauer has posted comments on this change. ( https://review.coreboot.org/c/em100/+/36051 )
Change subject: Fix whitespace error ......................................................................
Patch Set 1:
Patch Set 1: Code-Review+2
I wonder why it doesn't build
cp: cannot stat '/data/cache/EM100Pro.msi': No such file or directory
Because the builder is missing the Windows Installer blob and is not allowed to grab it from the internet.
Martin, can you please take a look?
Stefan Reinauer has posted comments on this change. ( https://review.coreboot.org/c/em100/+/36051 )
Change subject: Fix whitespace error ......................................................................
Patch Set 2: Code-Review+2
Stefan Reinauer has submitted this change. ( https://review.coreboot.org/c/em100/+/36051 )
Change subject: Fix whitespace error ......................................................................
Fix whitespace error
Signed-off-by: Patrick Rudolph patrick.rudolph@9elements.com Change-Id: I5b2492668b1b41afb4c32b24cbf9554783767311 Reviewed-on: https://review.coreboot.org/c/em100/+/36051 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Stefan Reinauer stefan.reinauer@coreboot.org Reviewed-by: Paul Menzel paulepanter@users.sourceforge.net Reviewed-by: Angel Pons th3fanbus@gmail.com --- M em100.c 1 file changed, 1 insertion(+), 1 deletion(-)
Approvals: build bot (Jenkins): Verified Stefan Reinauer: Looks good to me, approved Paul Menzel: Looks good to me, but someone else must approve Angel Pons: Looks good to me, approved
diff --git a/em100.c b/em100.c index 1548450..215b233 100644 --- a/em100.c +++ b/em100.c @@ -597,7 +597,7 @@ " -c|--set CHIP: select chip emulation\n" " -d|--download FILE: download FILE into EM100pro\n" " -a|--start address: only works with -d (E.g. -d file.bin -a 0x300000)\n" - " -u|--upload FILE: upload from EM100pro into FILE\n" + " -u|--upload FILE: upload from EM100pro into FILE\n" " -r|--start: em100 shall run\n" " -s|--stop: em100 shall stop\n" " -v|--verify: verify EM100 content matches the file\n"
-
Angel Pons (Code Review) -
Patrick Rudolph (Code Review)
-
Paul Menzel (Code Review)
-
Stefan Reinauer (Code Review)