Attention is currently required from: David Wu, Ren Kuo, Shelley Chen, Subrata Banik, YH Lin.
Bob Moragues has posted comments on this change by Ren Kuo. ( https://review.coreboot.org/c/coreboot/+/83212?usp=email )
Change subject: mb/google/brox: Create jubilant variant ......................................................................
Patch Set 17:
(1 comment)
File src/mainboard/google/brox/variants/jubilant/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/83212/comment/6e90761a_9cb2c6b7?usp... : PS16, Line 1: fw_config : field STORAGE 2 3 : option STORAGE_UNKNOWN 0 : option STORAGE_UFS 1 : option STORAGE_NVME 2 : end : field WIFI_BT 4 4 : option WIFI_BT_CNVI 0 : option WIFI_BT_PCIE 1 : end : field DB_USB 11 12 : option DB_1A 0 : option DB_1A_LTE 1 : end : field FPMCU 17 18 : option FPMCU_ABSENT 0 : option FPMCU_NUVOTON 1 : end : end
This needs to match the config,star bits here: […]
This is what I came up with:
``` fw_config field RETIMER 0 1 option RETIMER_UNKNOWN 0 option RETIMER_BYPASS 1 option RETIMER_JHL8040 2 end field STORAGE 2 3 option STORAGE_UNKNOWN 0 option STORAGE_UFS 1 option STORAGE_NVME 2 end field WIFI_BT 4 4 option WIFI_BT_CNVI 0 option WIFI_BT_PCIE 1 end field AUDIO 5 7 option AUDIO_UNKNOWN 0 option AUDIO_REALTEK_ALC256 1 option AUDIO_REALTEK_ALC3287 2 end field UFC 8 9 option UFC_NONE 0 option UFC_USB 1 end field KB_BL 10 10 option KB_BL_ABSENT 0 option KB_BL_PRESENT 1 end field FPMCU 11 12 option FP_ABSENT 0 option FP_MCU_NUVOTON 1 end field ISH 13 13 option ISP_DISABLED 0 option ISP_ENABLED 1 end field DB_USB 14 15 option DB_1A 0 option DB_1A_LTE 1 end end
```