Attention is currently required from: Damien Zammit. Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/63519 )
Change subject: mb/hp/t620: Add new mainboard HP T620 thin client ......................................................................
Patch Set 1:
(6 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/63519/comment/cba7f069_fffcacc2 PS1, Line 9: This commit adds support for HP T620, work was done : during a coreboot hacking party! : Board is AMD Fam16kb with laptop ram. Based off biostar/a68n-5200 port. Please reflow for 72 characters per line.
https://review.coreboot.org/c/coreboot/+/63519/comment/7f0b90d1_46357b83 PS1, Line 16: SeaBIOS Which version?
https://review.coreboot.org/c/coreboot/+/63519/comment/2f18b804_5e24d6da PS1, Line 16: linux Which version?
https://review.coreboot.org/c/coreboot/+/63519/comment/24e4d6e4_24959b7f PS1, Line 23: Caveat: Without VGA ROM there are no displays. Is coreboot able to execute it too, or does it only work with SeaBIOS?
https://review.coreboot.org/c/coreboot/+/63519/comment/f772f657_40d7d9ad PS1, Line 23: VGA ROM 1. Video/VGA BIOS Option ROM 2. What version did you extract and test with?
Patchset:
PS1: It’s hard to review, as it’s unclear what stuff is copied, and what was adapted.
-
Paul Menzel (Code Review)