Hello Subrata Banik,
I'd like you to do a code review. Please visit
https://review.coreboot.org/c/coreboot/+/31283
to review the following change.
Change subject: mb/intel/coffeelake_rvp: Add cml_u board support ......................................................................
mb/intel/coffeelake_rvp: Add cml_u board support
This patch selects CML SoC to build CMLRVP board.
Change-Id: I5f81b47f33345edefa0a7064559d9531e1d20eff Signed-off-by: Subrata Banik subrata.banik@intel.com Signed-off-by: Maulik V Vaghela maulik.v.vaghela@intel.com --- M src/mainboard/intel/coffeelake_rvp/Kconfig M src/mainboard/intel/coffeelake_rvp/Kconfig.name M src/mainboard/intel/coffeelake_rvp/variants/baseboard/gpio.c 3 files changed, 11 insertions(+), 4 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/83/31283/1
diff --git a/src/mainboard/intel/coffeelake_rvp/Kconfig b/src/mainboard/intel/coffeelake_rvp/Kconfig index d2d4b81..185d756 100644 --- a/src/mainboard/intel/coffeelake_rvp/Kconfig +++ b/src/mainboard/intel/coffeelake_rvp/Kconfig @@ -1,4 +1,4 @@ -if BOARD_INTEL_COFFEELAKE_RVP11 || BOARD_INTEL_COFFEELAKE_RVPU || BOARD_INTEL_WHISKEYLAKE_RVP || BOARD_INTEL_COFFEELAKE_RVP8 +if BOARD_INTEL_COFFEELAKE_RVP11 || BOARD_INTEL_COFFEELAKE_RVPU || BOARD_INTEL_WHISKEYLAKE_RVP || BOARD_INTEL_COFFEELAKE_RVP8 || BOARD_INTEL_COMETLAKE_RVP
config BOARD_SPECIFIC_OPTIONS def_bool y @@ -13,8 +13,8 @@ select DRIVERS_I2C_HID select DRIVERS_I2C_GENERIC select SOC_INTEL_CANNONLAKE_PCH_H if BOARD_INTEL_COFFEELAKE_RVP11 || BOARD_INTEL_COFFEELAKE_RVP8 - select SOC_INTEL_COMMON_BLOCK_HDA_VERB if BOARD_INTEL_COFFEELAKE_RVP11 || BOARD_INTEL_COFFEELAKE_RVP8 || BOARD_INTEL_WHISKEYLAKE_RVP - select SOC_INTEL_COMMON_BLOCK_HDA if BOARD_INTEL_WHISKEYLAKE_RVP + select SOC_INTEL_COMMON_BLOCK_HDA_VERB if !BOARD_INTEL_COFFEELAKE_RVPU + select SOC_INTEL_COMMON_BLOCK_HDA if BOARD_INTEL_WHISKEYLAKE_RVP || BOARD_INTEL_COMETLAKE_RVP select MAINBOARD_USES_IFD_EC_REGION select MAINBOARD_USES_IFD_GBE_REGION if BOARD_INTEL_COFFEELAKE_RVP11 || BOARD_INTEL_COFFEELAKE_RVP8
@@ -28,10 +28,12 @@ default "cfl_h" if BOARD_INTEL_COFFEELAKE_RVP11 default "whl_u" if BOARD_INTEL_WHISKEYLAKE_RVP default "cfl_s" if BOARD_INTEL_COFFEELAKE_RVP8 + default "cml_u" if BOARD_INTEL_COMETLAKE_RVP
config MAINBOARD_PART_NUMBER string default "whlrvp" if BOARD_INTEL_WHISKEYLAKE_RVP + default "cmlrvp" if BOARD_INTEL_COMETLAKE_RVP default "cflrvp"
config MAINBOARD_VENDOR @@ -41,6 +43,7 @@ config MAINBOARD_FAMILY string default "Intel_whlrvp" if BOARD_INTEL_WHISKEYLAKE_RVP + default "Intel_cmlrvp" if BOARD_INTEL_COMETLAKE_RVP default "Intel_cflrvp"
config CHROMEOS diff --git a/src/mainboard/intel/coffeelake_rvp/Kconfig.name b/src/mainboard/intel/coffeelake_rvp/Kconfig.name index 70652ef..35c0f0f 100644 --- a/src/mainboard/intel/coffeelake_rvp/Kconfig.name +++ b/src/mainboard/intel/coffeelake_rvp/Kconfig.name @@ -12,3 +12,6 @@ config BOARD_INTEL_COFFEELAKE_RVP8 bool "-> Coffeelake S U-DIMM DDR4 RVP8" select SOC_INTEL_COFFEELAKE +config BOARD_INTEL_COMETLAKE_RVP + bool "-> Cometlake U DDR4 RVP" + select SOC_INTEL_COMETLAKE diff --git a/src/mainboard/intel/coffeelake_rvp/variants/baseboard/gpio.c b/src/mainboard/intel/coffeelake_rvp/variants/baseboard/gpio.c index fc35050..ed43317 100644 --- a/src/mainboard/intel/coffeelake_rvp/variants/baseboard/gpio.c +++ b/src/mainboard/intel/coffeelake_rvp/variants/baseboard/gpio.c @@ -264,7 +264,8 @@ /* H21 : GPPC_H_21 */ /* H22 : GPPC_H_22 */ PAD_CFG_GPI(GPP_H22, NONE, DEEP), -#if IS_ENABLED(CONFIG_BOARD_INTEL_WHISKEYLAKE_RVP) +#if IS_ENABLED(CONFIG_BOARD_INTEL_WHISKEYLAKE_RVP) || \ + IS_ENABLED(CONFIG_BOARD_INTEL_COMETLAKE_RVP) PAD_CFG_GPO(GPP_H22, 1, PLTRST), #else PAD_CFG_GPI(GPP_H22, NONE, DEEP),
Hello Subrata Banik, build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/31283
to look at the new patch set (#2).
Change subject: mb/intel/coffeelake_rvp: Add cml_u board support ......................................................................
mb/intel/coffeelake_rvp: Add cml_u board support
This patch adds support to select CMLRVP board. Currently enabling CMLRVP on Coffeelake SOC, later will switch to cometlake soc once FSP binaries and headers are available.
Change-Id: I5f81b47f33345edefa0a7064559d9531e1d20eff Signed-off-by: Subrata Banik subrata.banik@intel.com Signed-off-by: Maulik V Vaghela maulik.v.vaghela@intel.com --- M src/mainboard/intel/coffeelake_rvp/Kconfig M src/mainboard/intel/coffeelake_rvp/Kconfig.name M src/mainboard/intel/coffeelake_rvp/variants/baseboard/gpio.c 3 files changed, 11 insertions(+), 4 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/83/31283/2
Maulik V Vaghela has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31283 )
Change subject: mb/intel/coffeelake_rvp: Add cml_u board support ......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/#/c/31283/2/src/mainboard/intel/coffeelake_rvp/K... File src/mainboard/intel/coffeelake_rvp/Kconfig:
https://review.coreboot.org/#/c/31283/2/src/mainboard/intel/coffeelake_rvp/K... PS2, Line 16: !BOARD_INTEL_COFFEELAKE_RVPU Kconfig used to select all boards except BOARD_INTEL_COFFEELAKE_RVPU, so changing it.
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31283 )
Change subject: mb/intel/coffeelake_rvp: Add cml_u board support ......................................................................
Patch Set 5:
(1 comment)
https://review.coreboot.org/#/c/31283/5//COMMIT_MSG Commit Message:
https://review.coreboot.org/#/c/31283/5//COMMIT_MSG@10 PS5, Line 10: Tested how?
Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31283 )
Change subject: mb/intel/coffeelake_rvp: Add cml_u board support ......................................................................
Patch Set 5:
(1 comment)
https://review.coreboot.org/#/c/31283/5/src/mainboard/intel/coffeelake_rvp/K... File src/mainboard/intel/coffeelake_rvp/Kconfig:
https://review.coreboot.org/#/c/31283/5/src/mainboard/intel/coffeelake_rvp/K... PS5, Line 1: BOARD_INTEL_COFFEELAKE_RVP11 || BOARD_INTEL_COFFEELAKE_RVPU || BOARD_INTEL_WHISKEYLAKE_RVP || BOARD_INTEL_COFFEELAKE_RVP8 || BOARD_INTEL_COMETLAKE_RVP It might be easier to just do something like if BOARD_INTEL_COFFEELAKE_RVP and select that in Kconfig.name
Hello Naresh Solanki, Aaron Durbin, Subrata Banik, Aamir Bohra, Duncan Laurie, Rizwan Qureshi, Shelley Chen, V Sowmya, build bot (Jenkins), Furquan Shaikh,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/31283
to look at the new patch set (#6).
Change subject: mb/intel/coffeelake_rvp: Add cml_u board support ......................................................................
mb/intel/coffeelake_rvp: Add cml_u board support
This patch adds support to select CMLRVP board.
Change-Id: I5f81b47f33345edefa0a7064559d9531e1d20eff Signed-off-by: Subrata Banik subrata.banik@intel.com Signed-off-by: Maulik V Vaghela maulik.v.vaghela@intel.com --- M src/mainboard/intel/coffeelake_rvp/Kconfig M src/mainboard/intel/coffeelake_rvp/Kconfig.name M src/mainboard/intel/coffeelake_rvp/variants/baseboard/gpio.c 3 files changed, 14 insertions(+), 4 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/83/31283/6
Maulik V Vaghela has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31283 )
Change subject: mb/intel/coffeelake_rvp: Add cml_u board support ......................................................................
Patch Set 6:
(1 comment)
https://review.coreboot.org/#/c/31283/5/src/mainboard/intel/coffeelake_rvp/K... File src/mainboard/intel/coffeelake_rvp/Kconfig:
https://review.coreboot.org/#/c/31283/5/src/mainboard/intel/coffeelake_rvp/K... PS5, Line 1: BOARD_INTEL_COFFEELAKE_RVP11 || BOARD_INTEL_COFFEELAKE_RVPU || BOARD_INTEL_WHISKEYLAKE_RVP || BOARD_INTEL_COFFEELAKE_RVP8 || BOARD_INTEL_COMETLAKE_RVP
It might be easier to just do something like […]
Yes Furquan, I'll look into that, since we may need to add BOARD_INTEL_COFFEELAKE_RVP somewhere outside board's Kconfig. Adding it in Kconfig.name will expose it in menuconfig, so we may need to check for appropriate file.
Maulik V Vaghela has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31283 )
Change subject: mb/intel/coffeelake_rvp: Add cml_u board support ......................................................................
Patch Set 7:
(1 comment)
https://review.coreboot.org/#/c/31283/5//COMMIT_MSG Commit Message:
https://review.coreboot.org/#/c/31283/5//COMMIT_MSG@10 PS5, Line 10:
Tested how?
I have tested this patch with build system as well as on real board. Build system shows CMLRVP and board also boots with compiled coreboot image.
Hello Naresh Solanki, Aaron Durbin, Subrata Banik, Aamir Bohra, Duncan Laurie, Rizwan Qureshi, Shelley Chen, V Sowmya, build bot (Jenkins), Furquan Shaikh,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/31283
to look at the new patch set (#8).
Change subject: mb/intel/coffeelake_rvp: Add cml_u board support ......................................................................
mb/intel/coffeelake_rvp: Add cml_u board support
This patch adds support to select CMLRVP board.
Change-Id: I5f81b47f33345edefa0a7064559d9531e1d20eff Signed-off-by: Subrata Banik subrata.banik@intel.com Signed-off-by: Maulik V Vaghela maulik.v.vaghela@intel.com --- M src/mainboard/intel/coffeelake_rvp/Kconfig M src/mainboard/intel/coffeelake_rvp/Kconfig.name M src/mainboard/intel/coffeelake_rvp/variants/baseboard/gpio.c 3 files changed, 11 insertions(+), 4 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/83/31283/8
Hello Naresh Solanki, Aaron Durbin, Subrata Banik, Aamir Bohra, Duncan Laurie, Rizwan Qureshi, Shelley Chen, V Sowmya, build bot (Jenkins), Furquan Shaikh,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/31283
to look at the new patch set (#12).
Change subject: mb/intel/coffeelake_rvp: Add cml_u board support ......................................................................
mb/intel/coffeelake_rvp: Add cml_u board support
This patch adds support to select CMLRVP board.
Change-Id: I5f81b47f33345edefa0a7064559d9531e1d20eff Signed-off-by: Subrata Banik subrata.banik@intel.com Signed-off-by: Maulik V Vaghela maulik.v.vaghela@intel.com --- M src/mainboard/intel/coffeelake_rvp/Kconfig M src/mainboard/intel/coffeelake_rvp/Kconfig.name M src/mainboard/intel/coffeelake_rvp/variants/baseboard/gpio.c 3 files changed, 11 insertions(+), 4 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/83/31283/12
Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31283 )
Change subject: mb/intel/coffeelake_rvp: Add cml_u board support ......................................................................
Patch Set 16:
This should just be squashed into the previous CL. Both are basically enabling support for a new board variant.
Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31283 )
Change subject: mb/intel/coffeelake_rvp: Add cml_u board support ......................................................................
Patch Set 16: Code-Review+2
Subrata Banik has submitted this change and it was merged. ( https://review.coreboot.org/c/coreboot/+/31283 )
Change subject: mb/intel/coffeelake_rvp: Add cml_u board support ......................................................................
mb/intel/coffeelake_rvp: Add cml_u board support
This patch adds support to select CMLRVP board.
Change-Id: I5f81b47f33345edefa0a7064559d9531e1d20eff Signed-off-by: Subrata Banik subrata.banik@intel.com Signed-off-by: Maulik V Vaghela maulik.v.vaghela@intel.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/31283 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Furquan Shaikh furquan@google.com --- M src/mainboard/intel/coffeelake_rvp/Kconfig M src/mainboard/intel/coffeelake_rvp/Kconfig.name M src/mainboard/intel/coffeelake_rvp/variants/baseboard/gpio.c 3 files changed, 11 insertions(+), 4 deletions(-)
Approvals: build bot (Jenkins): Verified Furquan Shaikh: Looks good to me, approved
diff --git a/src/mainboard/intel/coffeelake_rvp/Kconfig b/src/mainboard/intel/coffeelake_rvp/Kconfig index d2d4b81..185d756 100644 --- a/src/mainboard/intel/coffeelake_rvp/Kconfig +++ b/src/mainboard/intel/coffeelake_rvp/Kconfig @@ -1,4 +1,4 @@ -if BOARD_INTEL_COFFEELAKE_RVP11 || BOARD_INTEL_COFFEELAKE_RVPU || BOARD_INTEL_WHISKEYLAKE_RVP || BOARD_INTEL_COFFEELAKE_RVP8 +if BOARD_INTEL_COFFEELAKE_RVP11 || BOARD_INTEL_COFFEELAKE_RVPU || BOARD_INTEL_WHISKEYLAKE_RVP || BOARD_INTEL_COFFEELAKE_RVP8 || BOARD_INTEL_COMETLAKE_RVP
config BOARD_SPECIFIC_OPTIONS def_bool y @@ -13,8 +13,8 @@ select DRIVERS_I2C_HID select DRIVERS_I2C_GENERIC select SOC_INTEL_CANNONLAKE_PCH_H if BOARD_INTEL_COFFEELAKE_RVP11 || BOARD_INTEL_COFFEELAKE_RVP8 - select SOC_INTEL_COMMON_BLOCK_HDA_VERB if BOARD_INTEL_COFFEELAKE_RVP11 || BOARD_INTEL_COFFEELAKE_RVP8 || BOARD_INTEL_WHISKEYLAKE_RVP - select SOC_INTEL_COMMON_BLOCK_HDA if BOARD_INTEL_WHISKEYLAKE_RVP + select SOC_INTEL_COMMON_BLOCK_HDA_VERB if !BOARD_INTEL_COFFEELAKE_RVPU + select SOC_INTEL_COMMON_BLOCK_HDA if BOARD_INTEL_WHISKEYLAKE_RVP || BOARD_INTEL_COMETLAKE_RVP select MAINBOARD_USES_IFD_EC_REGION select MAINBOARD_USES_IFD_GBE_REGION if BOARD_INTEL_COFFEELAKE_RVP11 || BOARD_INTEL_COFFEELAKE_RVP8
@@ -28,10 +28,12 @@ default "cfl_h" if BOARD_INTEL_COFFEELAKE_RVP11 default "whl_u" if BOARD_INTEL_WHISKEYLAKE_RVP default "cfl_s" if BOARD_INTEL_COFFEELAKE_RVP8 + default "cml_u" if BOARD_INTEL_COMETLAKE_RVP
config MAINBOARD_PART_NUMBER string default "whlrvp" if BOARD_INTEL_WHISKEYLAKE_RVP + default "cmlrvp" if BOARD_INTEL_COMETLAKE_RVP default "cflrvp"
config MAINBOARD_VENDOR @@ -41,6 +43,7 @@ config MAINBOARD_FAMILY string default "Intel_whlrvp" if BOARD_INTEL_WHISKEYLAKE_RVP + default "Intel_cmlrvp" if BOARD_INTEL_COMETLAKE_RVP default "Intel_cflrvp"
config CHROMEOS diff --git a/src/mainboard/intel/coffeelake_rvp/Kconfig.name b/src/mainboard/intel/coffeelake_rvp/Kconfig.name index 70652ef..35c0f0f 100644 --- a/src/mainboard/intel/coffeelake_rvp/Kconfig.name +++ b/src/mainboard/intel/coffeelake_rvp/Kconfig.name @@ -12,3 +12,6 @@ config BOARD_INTEL_COFFEELAKE_RVP8 bool "-> Coffeelake S U-DIMM DDR4 RVP8" select SOC_INTEL_COFFEELAKE +config BOARD_INTEL_COMETLAKE_RVP + bool "-> Cometlake U DDR4 RVP" + select SOC_INTEL_COMETLAKE diff --git a/src/mainboard/intel/coffeelake_rvp/variants/baseboard/gpio.c b/src/mainboard/intel/coffeelake_rvp/variants/baseboard/gpio.c index b0091bd..e345146 100644 --- a/src/mainboard/intel/coffeelake_rvp/variants/baseboard/gpio.c +++ b/src/mainboard/intel/coffeelake_rvp/variants/baseboard/gpio.c @@ -264,7 +264,8 @@ /* H21 : GPPC_H_21 */ /* H22 : GPPC_H_22 */ PAD_CFG_GPI(GPP_H22, NONE, DEEP), -#if CONFIG(BOARD_INTEL_WHISKEYLAKE_RVP) +#if IS_ENABLED(CONFIG_BOARD_INTEL_WHISKEYLAKE_RVP) || \ + IS_ENABLED(CONFIG_BOARD_INTEL_COMETLAKE_RVP) PAD_CFG_GPO(GPP_H22, 1, PLTRST), #else PAD_CFG_GPI(GPP_H22, NONE, DEEP),
-
Furquan Shaikh (Code Review) -
Maulik V Vaghela (Code Review)
-
Paul Menzel (Code Review)
-
Subrata Banik (Code Review)