Attention is currently required from: Angel Pons, Matt DeVillier, Paul Menzel.
Sean Rhodes has posted comments on this change by Sean Rhodes. ( https://review.coreboot.org/c/coreboot/+/81409?usp=email )
Change subject: i2c/drivers/generic: Add support for including a CDM ......................................................................
Patch Set 11:
(3 comments)
File src/drivers/i2c/generic/chip.h:
https://review.coreboot.org/c/coreboot/+/81409/comment/3bc9757b_76cb0407?usp... : PS10, Line 87: * 1: 90 Degrees : * 2: 270 Degrees : * 3: 180 Degress : * 4: 0 Degress : * 5: 90 Degrees (Inverted) : * 6: 270 Degrees (Inverted) : * 7: 180 Degress (Inverted) : * 8: 0 Degress (Inverted)
Done
https://review.coreboot.org/c/coreboot/+/81409/comment/2904bd1f_6a4e7bfa?usp... : PS10, Line 99: CDM_NOT_PRESENT = 0,
Done
File src/drivers/i2c/generic/generic.c:
https://review.coreboot.org/c/coreboot/+/81409/comment/24ef631b_fa4ac156?usp... : PS10, Line 169: config->cdm_index
nit: […]
Done