Patrick Georgi has submitted this change. ( https://review.coreboot.org/c/coreboot/+/49791 )
Change subject: mb/google/dedede/var/sasuke: Configure GPP_G7 as native ......................................................................
mb/google/dedede/var/sasuke: Configure GPP_G7 as native
Configuring GPP_G7 as NC causes SD card detection issue on sasuke. So we'd like to remove the GPP_G7 override and keep the baseboard configuration as native function (SDIO_WP).
BUG=b:175831709 BRANCH=firmware-dedede-13606.B TEST=Built and verified SDR104 SD card operation on sasuke
Change-Id: If73337b482f04fd263caaa6fed0e54aa87bd876e Signed-off-by: Seunghwan Kim sh_.kim@samsung.corp-partner.google.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/49791 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Jamie Chen jamie.chen@intel.com Reviewed-by: Karthik Ramasubramanian kramasub@google.com --- M src/mainboard/google/dedede/variants/sasuke/gpio.c 1 file changed, 0 insertions(+), 3 deletions(-)
Approvals: build bot (Jenkins): Verified Karthik Ramasubramanian: Looks good to me, approved Jamie Chen: Looks good to me, but someone else must approve
diff --git a/src/mainboard/google/dedede/variants/sasuke/gpio.c b/src/mainboard/google/dedede/variants/sasuke/gpio.c index 3654973..8747b80 100644 --- a/src/mainboard/google/dedede/variants/sasuke/gpio.c +++ b/src/mainboard/google/dedede/variants/sasuke/gpio.c @@ -48,9 +48,6 @@ /* E2 : CLK_24M_WCAM ==> NC */ PAD_NC(GPP_E2, NONE),
- /* G7 : SD_SDIO_WP ==> NC */ - PAD_NC(GPP_G7, NONE), - /* H4 : AP_I2C_TS_SDA ==> NC */ PAD_NC(GPP_H4, NONE), /* H5 : AP_I2C_TS_SCL ==> NC */