Attention is currently required from: Arthur Heymans. build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/63004 )
Change subject: Move common EFI and FSP definitions to commonlib ......................................................................
Patch Set 1:
(5 comments)
File src/commonlib/include/commonlib/fsp_info_header.h:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-144480): https://review.coreboot.org/c/coreboot/+/63004/comment/8a3545ee_022a1f56 PS1, Line 51: struct FSP_EXTENTED_HEADER { 'EXTENTED' may be misspelled - perhaps 'EXTENDED'?
File src/commonlib/include/commonlib/uefi_types.h:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-144480): https://review.coreboot.org/c/coreboot/+/63004/comment/e5055803_51814766 PS1, Line 23: #define SIGNATURE_32(A, B, C, D) (SIGNATURE_16 (A, B) | (SIGNATURE_16 (C, D) << 16)) space prohibited between function name and open parenthesis '('
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-144480): https://review.coreboot.org/c/coreboot/+/63004/comment/2030a5ac_a7e59373 PS1, Line 23: #define SIGNATURE_32(A, B, C, D) (SIGNATURE_16 (A, B) | (SIGNATURE_16 (C, D) << 16)) space prohibited between function name and open parenthesis '('
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-144480): https://review.coreboot.org/c/coreboot/+/63004/comment/bb1b6b78_4d6814c1 PS1, Line 27: #define EFI_FVH_SIGNATURE SIGNATURE_32 ('_', 'F', 'V', 'H') space prohibited between function name and open parenthesis '('
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-144480): https://review.coreboot.org/c/coreboot/+/63004/comment/38c8bf00_75a44497 PS1, Line 27: #define EFI_FVH_SIGNATURE SIGNATURE_32 ('_', 'F', 'V', 'H') Macros with complex values should be enclosed in parentheses
-
build bot (Jenkins) (Code Review)