Attention is currently required from: Raul Rangel, Jon Murphy, Mark Hasemeyer.
Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74276 )
Change subject: mb/google/myst: Enable audo co-processor in devicetree
......................................................................
Patch Set 9:
(1 comment)
File src/mainboard/google/myst/variants/baseboard/devicetree.cb:
https://review.coreboot.org/c/coreboot/+/74276/comment/a96ea306_faf434f6
PS9, Line 93: device ref acp on end # Audio Processor (ACP)
would be good to add the devices in the order they are in the chipset devicetree which corresponds to the order of the device functions on the bus and not alphabetically
--
To view, visit
https://review.coreboot.org/c/coreboot/+/74276
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I1e1749359804960bbd75d869385b9071e7f33be7
Gerrit-Change-Number: 74276
Gerrit-PatchSet: 9
Gerrit-Owner: Jon Murphy
jpmurphy@google.com
Gerrit-Reviewer: Eric Lai
eric_lai@quanta.corp-partner.google.com
Gerrit-Reviewer: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Reviewer: Mark Hasemeyer
markhas@google.com
Gerrit-Reviewer: Raul Rangel
rrangel@chromium.org
Gerrit-Reviewer: Tim Van Patten
timvp@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Felix Held
felix-coreboot@felixheld.de
Gerrit-Attention: Raul Rangel
rrangel@chromium.org
Gerrit-Attention: Jon Murphy
jpmurphy@google.com
Gerrit-Attention: Mark Hasemeyer
markhas@google.com
Gerrit-Comment-Date: Thu, 13 Apr 2023 13:24:52 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment