Change in ...coreboot[master]: autoport: Support bigger ACPI tables

[Iru Cai (vimacs) (Code Review)]

Hello Iru Cai,

I'd like you to do a code review. Please visit

https://review.coreboot.org/c/coreboot/+/31759

to review the following change.

Change subject: autoport: Support bigger ACPI tables
......................................................................

autoport: Support bigger ACPI tables

DSDT can be bigger than 0x10000 bytes.

Change-Id: Iaadcfd0964c1c516e9e39d6cbfe41ec9a8c45e9d
Signed-off-by: Iru Cai 
---
M util/autoport/log_reader.go
1 file changed, 3 insertions(+), 3 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/59/31759/1

diff --git a/util/autoport/log_reader.go b/util/autoport/log_reader.go
index d9a687a..0aaf6a9 100644
--- a/util/autoport/log_reader.go
+++ b/util/autoport/log_reader.go
@@ -107,12 +107,12 @@
    curTable := ""
    for scanner.Scan() {
    	line := scanner.Text()
-		/* Only supports ACPI tables up to 0x10000 in size, FIXME if needed */
-		is_hexline, _ := regexp.MatchString(" *[0-9A-Fa-f]{4}: ", line)
+		/* Only supports ACPI tables up to 0x100000 in size, FIXME if needed */
+		is_hexline, _ := regexp.MatchString(" *[0-9A-Fa-f]{4,5}: ", line)
    	switch {
    	case len(line) >= 6 && line[5] == '@':
    		curTable = line[0:4]
-			Tables[curTable] = make([]byte, 0, 100000)
+			Tables[curTable] = make([]byte, 0, 0x100000)
    	case is_hexline:
    		Tables[curTable] = l.AssignHexLine(line, Tables[curTable])
    	}

[Paul Menzel (Code Review)]

Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31759 )

Change subject: autoport: Support bigger ACPI tables
......................................................................

Patch Set 1:

(1 comment)

https://review.coreboot.org/#/c/31759/1//COMMIT_MSG 
Commit Message:

https://review.coreboot.org/#/c/31759/1//COMMIT_MSG@9 
PS1, Line 9: DSDT can be bigger than 0x10000 bytes.
… so increase it by 16 times to … bytes.

[Angel Pons (Code Review)]

Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31759 )

Change subject: autoport: Support bigger ACPI tables
......................................................................

Patch Set 1: Code-Review+1

[Iru Cai (vimacs) (Code Review)]

Hello Iru Cai, Angel Pons, build bot (Jenkins),

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/31759

to look at the new patch set (#2).

Change subject: autoport: Support bigger ACPI tables
......................................................................

autoport: Support bigger ACPI tables

DSDT can be bigger than 0x10000 bytes, so increase the space up to 1MB
for an ACPI table and support lines in acpidump.log with address
higher than 0x10000.

Change-Id: Iaadcfd0964c1c516e9e39d6cbfe41ec9a8c45e9d
Signed-off-by: Iru Cai 
---
M util/autoport/log_reader.go
1 file changed, 3 insertions(+), 3 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/59/31759/2

[Paul Menzel (Code Review)]

Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31759 )

Change subject: autoport: Support bigger ACPI tables
......................................................................

Patch Set 3: Code-Review+1

Change in coreboot[master]: autoport: Support bigger ACPI tables

[Iru Cai (vimacs) (Code Review)]

Iru Cai (vimacs) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31759 )

Change subject: autoport: Support bigger ACPI tables
......................................................................

Patch Set 5:

(1 comment)

https://review.coreboot.org/c/coreboot/+/31759/1//COMMIT_MSG 
Commit Message:

https://review.coreboot.org/c/coreboot/+/31759/1//COMMIT_MSG@9 
PS1, Line 9: DSDT can be bigger than 0x10000 bytes.
> … so increase it by 16 times to … bytes.

Done

Change in coreboot[master]: autoport: Support bigger ACPI tables

[Angel Pons (Code Review)]

Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31759 )

Change subject: autoport: Support bigger ACPI tables
......................................................................

Patch Set 5: Code-Review+2

Change in coreboot[master]: autoport: Support bigger ACPI tables

[Angel Pons (Code Review)]

Angel Pons has submitted this change. ( https://review.coreboot.org/c/coreboot/+/31759 )

Change subject: autoport: Support bigger ACPI tables
......................................................................

autoport: Support bigger ACPI tables

DSDT can be bigger than 0x10000 bytes, so increase the space up to 1MB
for an ACPI table and support lines in acpidump.log with address
higher than 0x10000.

Change-Id: Iaadcfd0964c1c516e9e39d6cbfe41ec9a8c45e9d
Signed-off-by: Iru Cai 
Reviewed-on: https://review.coreboot.org/c/coreboot/+/31759
Reviewed-by: Angel Pons 
Reviewed-by: Paul Menzel 
Tested-by: build bot (Jenkins) 
---
M util/autoport/log_reader.go
1 file changed, 3 insertions(+), 3 deletions(-)

Approvals:
  build bot (Jenkins): Verified
  Paul Menzel: Looks good to me, but someone else must approve
  Angel Pons: Looks good to me, approved

diff --git a/util/autoport/log_reader.go b/util/autoport/log_reader.go
index d9a687a..0aaf6a9 100644
--- a/util/autoport/log_reader.go
+++ b/util/autoport/log_reader.go
@@ -107,12 +107,12 @@
    curTable := ""
    for scanner.Scan() {
    	line := scanner.Text()
-		/* Only supports ACPI tables up to 0x10000 in size, FIXME if needed */
-		is_hexline, _ := regexp.MatchString(" *[0-9A-Fa-f]{4}: ", line)
+		/* Only supports ACPI tables up to 0x100000 in size, FIXME if needed */
+		is_hexline, _ := regexp.MatchString(" *[0-9A-Fa-f]{4,5}: ", line)
    	switch {
    	case len(line) >= 6 && line[5] == '@':
    		curTable = line[0:4]
-			Tables[curTable] = make([]byte, 0, 100000)
+			Tables[curTable] = make([]byte, 0, 0x100000)
    	case is_hexline:
    		Tables[curTable] = l.AssignHexLine(line, Tables[curTable])
    	}