Attention is currently required from: Jason Glenesk, Matt DeVillier, Felix Held.
build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/69069 )
Change subject: soc/amd/picasso/data_fabric: Add register bitslice struct ......................................................................
Patch Set 1:
(5 comments)
File src/soc/amd/picasso/include/soc/data_fabric.h:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-161869): https://review.coreboot.org/c/coreboot/+/69069/comment/1ddd4def_1b78fe59 PS1, Line 21: uint32_t : 2; /* [ 3.. 2] */ space prohibited before that ':' (ctx:WxW)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-161869): https://review.coreboot.org/c/coreboot/+/69069/comment/975d960d_a00a0cea PS1, Line 24: uint32_t : 19; /* [31..13] */ space prohibited before that ':' (ctx:WxW)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-161869): https://review.coreboot.org/c/coreboot/+/69069/comment/9f7302ba_28f1787f PS1, Line 32: uint32_t : 1; /* [ 1.. 1] */ space prohibited before that ':' (ctx:WxW)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-161869): https://review.coreboot.org/c/coreboot/+/69069/comment/565286ad_59da1268 PS1, Line 36: uint32_t : 1; /* [15..15] */ space prohibited before that ':' (ctx:WxW)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-161869): https://review.coreboot.org/c/coreboot/+/69069/comment/71b964e9_9b2de12d PS1, Line 38: uint32_t : 8; /* [31..24] */ space prohibited before that ':' (ctx:WxW)