[M] Change in coreboot[master]: drivers/phy/m88e1512: Provide functionality to customize LED status
Attention is currently required from: Werner Zeh.
Mario Scheithauer has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/69386 )
Change subject: drivers/phy/m88e1512: Provide functionality to customize LED status ......................................................................
Patch Set 4:
(2 comments)
File src/drivers/phy/m88e1512/m88e1512.h:
https://review.coreboot.org/c/coreboot/+/69386/comment/9f52f5fd_582dca36 PS3, Line 7: PHY_MDIO_PAGE_ANY_ADR_RE
This name is a bit misleading. In the linked datasheet this register is called 'Page Address'. […]
Ack. It looks better and makes it clearer. You are also right about the defines for the pages.
File src/drivers/phy/m88e1512/m88e1512.c:
https://review.coreboot.org/c/coreboot/+/69386/comment/02856151_aa3655ac PS3, Line 22: ...
Just one '.' should be suitable here.
Done
-
Mario Scheithauer (Code Review)