Angel Pons has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/43270 )
Change subject: ACPI: Drop commented-out DSDT DefinitionBlock instances ......................................................................
ACPI: Drop commented-out DSDT DefinitionBlock instances
This code is not even being build-tested. Drop it before it grows moss.
Change-Id: I9b5589d4596eead83a5897b083ccb85ef05a03d5 Signed-off-by: Angel Pons th3fanbus@gmail.com --- M src/arch/x86/acpi/debug.asl M src/mainboard/amd/gardenia/acpi/routing.asl M src/mainboard/amd/gardenia/acpi/usb_oc.asl M src/mainboard/amd/inagua/acpi/routing.asl M src/mainboard/amd/inagua/acpi/usb_oc.asl M src/mainboard/amd/olivehill/acpi/routing.asl M src/mainboard/amd/persimmon/acpi/routing.asl M src/mainboard/amd/persimmon/acpi/usb_oc.asl M src/mainboard/amd/south_station/acpi/routing.asl M src/mainboard/amd/south_station/acpi/usb_oc.asl M src/mainboard/amd/thatcher/acpi/cpstate.asl M src/mainboard/amd/union_station/acpi/routing.asl M src/mainboard/amd/union_station/acpi/usb_oc.asl M src/mainboard/asrock/e350m1/acpi/routing.asl M src/mainboard/asrock/e350m1/acpi/usb_oc.asl M src/mainboard/asrock/imb-a180/acpi/routing.asl M src/mainboard/asus/f2a85-m/acpi/cpstate.asl M src/mainboard/bap/ode_e20XX/acpi/routing.asl M src/mainboard/biostar/a68n_5200/acpi/routing.asl M src/mainboard/biostar/am1ml/acpi/routing.asl M src/mainboard/elmex/pcm205400/acpi/routing.asl M src/mainboard/elmex/pcm205400/acpi/usb_oc.asl M src/mainboard/gizmosphere/gizmo/acpi/routing.asl M src/mainboard/gizmosphere/gizmo/acpi/usb_oc.asl M src/mainboard/gizmosphere/gizmo2/acpi/routing.asl M src/mainboard/google/kahlee/variants/baseboard/include/baseboard/acpi/routing.asl M src/mainboard/hp/abm/acpi/routing.asl M src/mainboard/jetway/nf81-t56n-lf/acpi/routing.asl M src/mainboard/jetway/nf81-t56n-lf/acpi/usb_oc.asl M src/mainboard/lippert/frontrunner-af/acpi/routing.asl M src/mainboard/lippert/frontrunner-af/acpi/usb.asl M src/mainboard/lippert/toucan-af/acpi/routing.asl M src/mainboard/lippert/toucan-af/acpi/usb.asl M src/mainboard/msi/ms7721/acpi/cpstate.asl M src/mainboard/pcengines/apu1/acpi/routing.asl M src/mainboard/pcengines/apu1/acpi/usb_oc.asl M src/mainboard/pcengines/apu2/acpi/routing.asl M src/mainboard/pcengines/apu2/acpi/usb_oc.asl 38 files changed, 0 insertions(+), 412 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/70/43270/1
diff --git a/src/arch/x86/acpi/debug.asl b/src/arch/x86/acpi/debug.asl index 11651e4..fd071f8 100644 --- a/src/arch/x86/acpi/debug.asl +++ b/src/arch/x86/acpi/debug.asl @@ -1,21 +1,6 @@ /* SPDX-License-Identifier: GPL-2.0-only */
/* - #include <acpi/acpi.h> - DefinitionBlock ( - "DSDT.AML", - "DSDT", - 0x01, - OEM_ID, - ACPI_TABLE_CREATOR, - 0x00010001 - ) - { - #include "debug.asl" - } -*/ - -/* * 0x80: POST_BASE * 0x3F8: DEBCOM_BASE * X80: POST_REGION diff --git a/src/mainboard/amd/gardenia/acpi/routing.asl b/src/mainboard/amd/gardenia/acpi/routing.asl index 3e7d6e6..d4d1c4a 100644 --- a/src/mainboard/amd/gardenia/acpi/routing.asl +++ b/src/mainboard/amd/gardenia/acpi/routing.asl @@ -1,14 +1,5 @@ /* SPDX-License-Identifier: GPL-2.0-only */
-/* -#include <acpi/acpi.h> -DefinitionBlock ("DSDT.AML", "DSDT", 0x01, OEM_ID, ACPI_TABLE_CREATOR, 0x00010001 - ) - { - #include "routing.asl" - } -*/ - /* Routing is in System Bus scope */ Name(PR0, Package(){ /* NB devices */ diff --git a/src/mainboard/amd/gardenia/acpi/usb_oc.asl b/src/mainboard/amd/gardenia/acpi/usb_oc.asl index 4b7719c..b1e2210 100644 --- a/src/mainboard/amd/gardenia/acpi/usb_oc.asl +++ b/src/mainboard/amd/gardenia/acpi/usb_oc.asl @@ -1,15 +1,5 @@ /* SPDX-License-Identifier: GPL-2.0-only */
-/* simple name description */ -/* -#include <acpi/acpi.h> -DefinitionBlock ("DSDT.AML", "DSDT", 0x01, OEM_ID, ACPI_TABLE_CREATOR, 0x00010001 - ) - { - #include "usb.asl" - } -*/ - /* USB overcurrent mapping pins. */ Name(UOM0, 0) Name(UOM1, 2) diff --git a/src/mainboard/amd/inagua/acpi/routing.asl b/src/mainboard/amd/inagua/acpi/routing.asl index 7481f1d..2b5823f 100644 --- a/src/mainboard/amd/inagua/acpi/routing.asl +++ b/src/mainboard/amd/inagua/acpi/routing.asl @@ -1,14 +1,5 @@ /* SPDX-License-Identifier: GPL-2.0-only */
-/* -#include <acpi/acpi.h> -DefinitionBlock ("DSDT.AML", "DSDT", 0x01, OEM_ID, ACPI_TABLE_CREATOR, 0x00010001 - ) - { - #include "routing.asl" - } -*/ - /* Routing is in System Bus scope */ Scope(_SB) { Name(PR0, Package(){ diff --git a/src/mainboard/amd/inagua/acpi/usb_oc.asl b/src/mainboard/amd/inagua/acpi/usb_oc.asl index 63df0ef..4ecc52a 100644 --- a/src/mainboard/amd/inagua/acpi/usb_oc.asl +++ b/src/mainboard/amd/inagua/acpi/usb_oc.asl @@ -1,15 +1,5 @@ /* SPDX-License-Identifier: GPL-2.0-only */
-/* simple name description */ -/* -#include <acpi/acpi.h> -DefinitionBlock ("DSDT.AML", "DSDT", 0x01, OEM_ID, ACPI_TABLE_CREATOR, 0x00010001 - ) - { - #include "usb.asl" - } -*/ - /* USB overcurrent mapping pins. */ Name(UOM0, 0) Name(UOM1, 2) diff --git a/src/mainboard/amd/olivehill/acpi/routing.asl b/src/mainboard/amd/olivehill/acpi/routing.asl index d08e162..106259d 100644 --- a/src/mainboard/amd/olivehill/acpi/routing.asl +++ b/src/mainboard/amd/olivehill/acpi/routing.asl @@ -1,14 +1,5 @@ /* SPDX-License-Identifier: GPL-2.0-only */
-/* -#include <acpi/acpi.h> -DefinitionBlock ("DSDT.AML", "DSDT", 0x01, OEM_ID, ACPI_TABLE_CREATOR, 0x00010001 - ) - { - #include "routing.asl" - } -*/ - /* Routing is in System Bus scope */ Name(PR0, Package(){ /* NB devices */ diff --git a/src/mainboard/amd/persimmon/acpi/routing.asl b/src/mainboard/amd/persimmon/acpi/routing.asl index d039a7a..656a0be 100644 --- a/src/mainboard/amd/persimmon/acpi/routing.asl +++ b/src/mainboard/amd/persimmon/acpi/routing.asl @@ -1,14 +1,5 @@ /* SPDX-License-Identifier: GPL-2.0-only */
-/* -#include <acpi/acpi.h> -DefinitionBlock ("DSDT.AML", "DSDT", 0x01, OEM_ID, ACPI_TABLE_CREATOR, 0x00010001 - ) - { - #include "routing.asl" - } -*/ - /* Routing is in System Bus scope */ Scope(_SB) { Name(PR0, Package(){ diff --git a/src/mainboard/amd/persimmon/acpi/usb_oc.asl b/src/mainboard/amd/persimmon/acpi/usb_oc.asl index 63df0ef..4ecc52a 100644 --- a/src/mainboard/amd/persimmon/acpi/usb_oc.asl +++ b/src/mainboard/amd/persimmon/acpi/usb_oc.asl @@ -1,15 +1,5 @@ /* SPDX-License-Identifier: GPL-2.0-only */
-/* simple name description */ -/* -#include <acpi/acpi.h> -DefinitionBlock ("DSDT.AML", "DSDT", 0x01, OEM_ID, ACPI_TABLE_CREATOR, 0x00010001 - ) - { - #include "usb.asl" - } -*/ - /* USB overcurrent mapping pins. */ Name(UOM0, 0) Name(UOM1, 2) diff --git a/src/mainboard/amd/south_station/acpi/routing.asl b/src/mainboard/amd/south_station/acpi/routing.asl index 7481f1d..2b5823f 100644 --- a/src/mainboard/amd/south_station/acpi/routing.asl +++ b/src/mainboard/amd/south_station/acpi/routing.asl @@ -1,14 +1,5 @@ /* SPDX-License-Identifier: GPL-2.0-only */
-/* -#include <acpi/acpi.h> -DefinitionBlock ("DSDT.AML", "DSDT", 0x01, OEM_ID, ACPI_TABLE_CREATOR, 0x00010001 - ) - { - #include "routing.asl" - } -*/ - /* Routing is in System Bus scope */ Scope(_SB) { Name(PR0, Package(){ diff --git a/src/mainboard/amd/south_station/acpi/usb_oc.asl b/src/mainboard/amd/south_station/acpi/usb_oc.asl index 63df0ef..4ecc52a 100644 --- a/src/mainboard/amd/south_station/acpi/usb_oc.asl +++ b/src/mainboard/amd/south_station/acpi/usb_oc.asl @@ -1,15 +1,5 @@ /* SPDX-License-Identifier: GPL-2.0-only */
-/* simple name description */ -/* -#include <acpi/acpi.h> -DefinitionBlock ("DSDT.AML", "DSDT", 0x01, OEM_ID, ACPI_TABLE_CREATOR, 0x00010001 - ) - { - #include "usb.asl" - } -*/ - /* USB overcurrent mapping pins. */ Name(UOM0, 0) Name(UOM1, 2) diff --git a/src/mainboard/amd/thatcher/acpi/cpstate.asl b/src/mainboard/amd/thatcher/acpi/cpstate.asl index 2a0372e..494fc73 100644 --- a/src/mainboard/amd/thatcher/acpi/cpstate.asl +++ b/src/mainboard/amd/thatcher/acpi/cpstate.asl @@ -5,33 +5,6 @@ * core. It assumes that each core of the system has the same performance * characteristics. */ -/* -#include <acpi/acpi.h> -DefinitionBlock ("DSDT.AML", "DSDT", 0x01, OEM_ID, ACPI_TABLE_CREATOR, 0x00010001) - { - Scope (_SB) { - Device (CPU0) { - Name (_HID, "ACPI0007") - Name (_UID, 0) - #include "cpstate.asl" - } - Device (CPU1) { - Name (_HID, "ACPI0007") - Name (_UID, 1) - #include "cpstate.asl" - } - Device (CPU2) { - Name (_HID, "ACPI0007") - Name (_UID, 2) - #include "cpstate.asl" - } - Device (CPU3) { - Name (_HID, "ACPI0007") - Name (_UID, 3) - #include "cpstate.asl" - } - } -*/ /* P-state support: The maximum number of P-states supported by the */ /* CPUs we'll use is 6. */ /* Get from AMI BIOS. */ diff --git a/src/mainboard/amd/union_station/acpi/routing.asl b/src/mainboard/amd/union_station/acpi/routing.asl index 7481f1d..2b5823f 100644 --- a/src/mainboard/amd/union_station/acpi/routing.asl +++ b/src/mainboard/amd/union_station/acpi/routing.asl @@ -1,14 +1,5 @@ /* SPDX-License-Identifier: GPL-2.0-only */
-/* -#include <acpi/acpi.h> -DefinitionBlock ("DSDT.AML", "DSDT", 0x01, OEM_ID, ACPI_TABLE_CREATOR, 0x00010001 - ) - { - #include "routing.asl" - } -*/ - /* Routing is in System Bus scope */ Scope(_SB) { Name(PR0, Package(){ diff --git a/src/mainboard/amd/union_station/acpi/usb_oc.asl b/src/mainboard/amd/union_station/acpi/usb_oc.asl index 63df0ef..4ecc52a 100644 --- a/src/mainboard/amd/union_station/acpi/usb_oc.asl +++ b/src/mainboard/amd/union_station/acpi/usb_oc.asl @@ -1,15 +1,5 @@ /* SPDX-License-Identifier: GPL-2.0-only */
-/* simple name description */ -/* -#include <acpi/acpi.h> -DefinitionBlock ("DSDT.AML", "DSDT", 0x01, OEM_ID, ACPI_TABLE_CREATOR, 0x00010001 - ) - { - #include "usb.asl" - } -*/ - /* USB overcurrent mapping pins. */ Name(UOM0, 0) Name(UOM1, 2) diff --git a/src/mainboard/asrock/e350m1/acpi/routing.asl b/src/mainboard/asrock/e350m1/acpi/routing.asl index 8ea04e1..5fa77f0 100644 --- a/src/mainboard/asrock/e350m1/acpi/routing.asl +++ b/src/mainboard/asrock/e350m1/acpi/routing.asl @@ -1,14 +1,5 @@ /* SPDX-License-Identifier: GPL-2.0-only */
-/* -#include <acpi/acpi.h> -DefinitionBlock ("DSDT.AML", "DSDT", 0x01, OEM_ID, ACPI_TABLE_CREATOR, 0x00010001 - ) - { - #include "routing.asl" - } -*/ - /* Routing is in System Bus scope */ Scope(_SB) { Name(PR0, Package(){ diff --git a/src/mainboard/asrock/e350m1/acpi/usb_oc.asl b/src/mainboard/asrock/e350m1/acpi/usb_oc.asl index 63df0ef..4ecc52a 100644 --- a/src/mainboard/asrock/e350m1/acpi/usb_oc.asl +++ b/src/mainboard/asrock/e350m1/acpi/usb_oc.asl @@ -1,15 +1,5 @@ /* SPDX-License-Identifier: GPL-2.0-only */
-/* simple name description */ -/* -#include <acpi/acpi.h> -DefinitionBlock ("DSDT.AML", "DSDT", 0x01, OEM_ID, ACPI_TABLE_CREATOR, 0x00010001 - ) - { - #include "usb.asl" - } -*/ - /* USB overcurrent mapping pins. */ Name(UOM0, 0) Name(UOM1, 2) diff --git a/src/mainboard/asrock/imb-a180/acpi/routing.asl b/src/mainboard/asrock/imb-a180/acpi/routing.asl index d08e162..106259d 100644 --- a/src/mainboard/asrock/imb-a180/acpi/routing.asl +++ b/src/mainboard/asrock/imb-a180/acpi/routing.asl @@ -1,14 +1,5 @@ /* SPDX-License-Identifier: GPL-2.0-only */
-/* -#include <acpi/acpi.h> -DefinitionBlock ("DSDT.AML", "DSDT", 0x01, OEM_ID, ACPI_TABLE_CREATOR, 0x00010001 - ) - { - #include "routing.asl" - } -*/ - /* Routing is in System Bus scope */ Name(PR0, Package(){ /* NB devices */ diff --git a/src/mainboard/asus/f2a85-m/acpi/cpstate.asl b/src/mainboard/asus/f2a85-m/acpi/cpstate.asl index 2a0372e..494fc73 100644 --- a/src/mainboard/asus/f2a85-m/acpi/cpstate.asl +++ b/src/mainboard/asus/f2a85-m/acpi/cpstate.asl @@ -5,33 +5,6 @@ * core. It assumes that each core of the system has the same performance * characteristics. */ -/* -#include <acpi/acpi.h> -DefinitionBlock ("DSDT.AML", "DSDT", 0x01, OEM_ID, ACPI_TABLE_CREATOR, 0x00010001) - { - Scope (_SB) { - Device (CPU0) { - Name (_HID, "ACPI0007") - Name (_UID, 0) - #include "cpstate.asl" - } - Device (CPU1) { - Name (_HID, "ACPI0007") - Name (_UID, 1) - #include "cpstate.asl" - } - Device (CPU2) { - Name (_HID, "ACPI0007") - Name (_UID, 2) - #include "cpstate.asl" - } - Device (CPU3) { - Name (_HID, "ACPI0007") - Name (_UID, 3) - #include "cpstate.asl" - } - } -*/ /* P-state support: The maximum number of P-states supported by the */ /* CPUs we'll use is 6. */ /* Get from AMI BIOS. */ diff --git a/src/mainboard/bap/ode_e20XX/acpi/routing.asl b/src/mainboard/bap/ode_e20XX/acpi/routing.asl index d08e162..106259d 100644 --- a/src/mainboard/bap/ode_e20XX/acpi/routing.asl +++ b/src/mainboard/bap/ode_e20XX/acpi/routing.asl @@ -1,14 +1,5 @@ /* SPDX-License-Identifier: GPL-2.0-only */
-/* -#include <acpi/acpi.h> -DefinitionBlock ("DSDT.AML", "DSDT", 0x01, OEM_ID, ACPI_TABLE_CREATOR, 0x00010001 - ) - { - #include "routing.asl" - } -*/ - /* Routing is in System Bus scope */ Name(PR0, Package(){ /* NB devices */ diff --git a/src/mainboard/biostar/a68n_5200/acpi/routing.asl b/src/mainboard/biostar/a68n_5200/acpi/routing.asl index d08e162..106259d 100644 --- a/src/mainboard/biostar/a68n_5200/acpi/routing.asl +++ b/src/mainboard/biostar/a68n_5200/acpi/routing.asl @@ -1,14 +1,5 @@ /* SPDX-License-Identifier: GPL-2.0-only */
-/* -#include <acpi/acpi.h> -DefinitionBlock ("DSDT.AML", "DSDT", 0x01, OEM_ID, ACPI_TABLE_CREATOR, 0x00010001 - ) - { - #include "routing.asl" - } -*/ - /* Routing is in System Bus scope */ Name(PR0, Package(){ /* NB devices */ diff --git a/src/mainboard/biostar/am1ml/acpi/routing.asl b/src/mainboard/biostar/am1ml/acpi/routing.asl index d08e162..106259d 100644 --- a/src/mainboard/biostar/am1ml/acpi/routing.asl +++ b/src/mainboard/biostar/am1ml/acpi/routing.asl @@ -1,14 +1,5 @@ /* SPDX-License-Identifier: GPL-2.0-only */
-/* -#include <acpi/acpi.h> -DefinitionBlock ("DSDT.AML", "DSDT", 0x01, OEM_ID, ACPI_TABLE_CREATOR, 0x00010001 - ) - { - #include "routing.asl" - } -*/ - /* Routing is in System Bus scope */ Name(PR0, Package(){ /* NB devices */ diff --git a/src/mainboard/elmex/pcm205400/acpi/routing.asl b/src/mainboard/elmex/pcm205400/acpi/routing.asl index d039a7a..656a0be 100644 --- a/src/mainboard/elmex/pcm205400/acpi/routing.asl +++ b/src/mainboard/elmex/pcm205400/acpi/routing.asl @@ -1,14 +1,5 @@ /* SPDX-License-Identifier: GPL-2.0-only */
-/* -#include <acpi/acpi.h> -DefinitionBlock ("DSDT.AML", "DSDT", 0x01, OEM_ID, ACPI_TABLE_CREATOR, 0x00010001 - ) - { - #include "routing.asl" - } -*/ - /* Routing is in System Bus scope */ Scope(_SB) { Name(PR0, Package(){ diff --git a/src/mainboard/elmex/pcm205400/acpi/usb_oc.asl b/src/mainboard/elmex/pcm205400/acpi/usb_oc.asl index 63df0ef..4ecc52a 100644 --- a/src/mainboard/elmex/pcm205400/acpi/usb_oc.asl +++ b/src/mainboard/elmex/pcm205400/acpi/usb_oc.asl @@ -1,15 +1,5 @@ /* SPDX-License-Identifier: GPL-2.0-only */
-/* simple name description */ -/* -#include <acpi/acpi.h> -DefinitionBlock ("DSDT.AML", "DSDT", 0x01, OEM_ID, ACPI_TABLE_CREATOR, 0x00010001 - ) - { - #include "usb.asl" - } -*/ - /* USB overcurrent mapping pins. */ Name(UOM0, 0) Name(UOM1, 2) diff --git a/src/mainboard/gizmosphere/gizmo/acpi/routing.asl b/src/mainboard/gizmosphere/gizmo/acpi/routing.asl index 8ea04e1..5fa77f0 100644 --- a/src/mainboard/gizmosphere/gizmo/acpi/routing.asl +++ b/src/mainboard/gizmosphere/gizmo/acpi/routing.asl @@ -1,14 +1,5 @@ /* SPDX-License-Identifier: GPL-2.0-only */
-/* -#include <acpi/acpi.h> -DefinitionBlock ("DSDT.AML", "DSDT", 0x01, OEM_ID, ACPI_TABLE_CREATOR, 0x00010001 - ) - { - #include "routing.asl" - } -*/ - /* Routing is in System Bus scope */ Scope(_SB) { Name(PR0, Package(){ diff --git a/src/mainboard/gizmosphere/gizmo/acpi/usb_oc.asl b/src/mainboard/gizmosphere/gizmo/acpi/usb_oc.asl index 63df0ef..4ecc52a 100644 --- a/src/mainboard/gizmosphere/gizmo/acpi/usb_oc.asl +++ b/src/mainboard/gizmosphere/gizmo/acpi/usb_oc.asl @@ -1,15 +1,5 @@ /* SPDX-License-Identifier: GPL-2.0-only */
-/* simple name description */ -/* -#include <acpi/acpi.h> -DefinitionBlock ("DSDT.AML", "DSDT", 0x01, OEM_ID, ACPI_TABLE_CREATOR, 0x00010001 - ) - { - #include "usb.asl" - } -*/ - /* USB overcurrent mapping pins. */ Name(UOM0, 0) Name(UOM1, 2) diff --git a/src/mainboard/gizmosphere/gizmo2/acpi/routing.asl b/src/mainboard/gizmosphere/gizmo2/acpi/routing.asl index d08e162..106259d 100644 --- a/src/mainboard/gizmosphere/gizmo2/acpi/routing.asl +++ b/src/mainboard/gizmosphere/gizmo2/acpi/routing.asl @@ -1,14 +1,5 @@ /* SPDX-License-Identifier: GPL-2.0-only */
-/* -#include <acpi/acpi.h> -DefinitionBlock ("DSDT.AML", "DSDT", 0x01, OEM_ID, ACPI_TABLE_CREATOR, 0x00010001 - ) - { - #include "routing.asl" - } -*/ - /* Routing is in System Bus scope */ Name(PR0, Package(){ /* NB devices */ diff --git a/src/mainboard/google/kahlee/variants/baseboard/include/baseboard/acpi/routing.asl b/src/mainboard/google/kahlee/variants/baseboard/include/baseboard/acpi/routing.asl index fcf3958..72996ce 100644 --- a/src/mainboard/google/kahlee/variants/baseboard/include/baseboard/acpi/routing.asl +++ b/src/mainboard/google/kahlee/variants/baseboard/include/baseboard/acpi/routing.asl @@ -1,13 +1,5 @@ /* SPDX-License-Identifier: GPL-2.0-only */
-/* - * #include <acpi/acpi.h> -DefinitionBlock ("DSDT.AML", "DSDT", 0x01, OEM_ID, ACPI_TABLE_CREATOR, 0x00010001) - *{ - * #include "routing.asl" - *} - */ - /* Routing is in System Bus scope */ Name (PR0, Package() { diff --git a/src/mainboard/hp/abm/acpi/routing.asl b/src/mainboard/hp/abm/acpi/routing.asl index d08e162..106259d 100644 --- a/src/mainboard/hp/abm/acpi/routing.asl +++ b/src/mainboard/hp/abm/acpi/routing.asl @@ -1,14 +1,5 @@ /* SPDX-License-Identifier: GPL-2.0-only */
-/* -#include <acpi/acpi.h> -DefinitionBlock ("DSDT.AML", "DSDT", 0x01, OEM_ID, ACPI_TABLE_CREATOR, 0x00010001 - ) - { - #include "routing.asl" - } -*/ - /* Routing is in System Bus scope */ Name(PR0, Package(){ /* NB devices */ diff --git a/src/mainboard/jetway/nf81-t56n-lf/acpi/routing.asl b/src/mainboard/jetway/nf81-t56n-lf/acpi/routing.asl index d039a7a..656a0be 100644 --- a/src/mainboard/jetway/nf81-t56n-lf/acpi/routing.asl +++ b/src/mainboard/jetway/nf81-t56n-lf/acpi/routing.asl @@ -1,14 +1,5 @@ /* SPDX-License-Identifier: GPL-2.0-only */
-/* -#include <acpi/acpi.h> -DefinitionBlock ("DSDT.AML", "DSDT", 0x01, OEM_ID, ACPI_TABLE_CREATOR, 0x00010001 - ) - { - #include "routing.asl" - } -*/ - /* Routing is in System Bus scope */ Scope(_SB) { Name(PR0, Package(){ diff --git a/src/mainboard/jetway/nf81-t56n-lf/acpi/usb_oc.asl b/src/mainboard/jetway/nf81-t56n-lf/acpi/usb_oc.asl index 63df0ef..4ecc52a 100644 --- a/src/mainboard/jetway/nf81-t56n-lf/acpi/usb_oc.asl +++ b/src/mainboard/jetway/nf81-t56n-lf/acpi/usb_oc.asl @@ -1,15 +1,5 @@ /* SPDX-License-Identifier: GPL-2.0-only */
-/* simple name description */ -/* -#include <acpi/acpi.h> -DefinitionBlock ("DSDT.AML", "DSDT", 0x01, OEM_ID, ACPI_TABLE_CREATOR, 0x00010001 - ) - { - #include "usb.asl" - } -*/ - /* USB overcurrent mapping pins. */ Name(UOM0, 0) Name(UOM1, 2) diff --git a/src/mainboard/lippert/frontrunner-af/acpi/routing.asl b/src/mainboard/lippert/frontrunner-af/acpi/routing.asl index d2e9d4a..7b73e5d 100644 --- a/src/mainboard/lippert/frontrunner-af/acpi/routing.asl +++ b/src/mainboard/lippert/frontrunner-af/acpi/routing.asl @@ -1,14 +1,5 @@ /* SPDX-License-Identifier: GPL-2.0-only */
-/* -#include <acpi/acpi.h> -DefinitionBlock ("DSDT.AML", "DSDT", 0x01, OEM_ID, ACPI_TABLE_CREATOR, 0x00010001 - ) - { - #include "routing.asl" - } -*/ - /* Routing is in System Bus scope */ Scope(_SB) { Name(PR0, Package(){ diff --git a/src/mainboard/lippert/frontrunner-af/acpi/usb.asl b/src/mainboard/lippert/frontrunner-af/acpi/usb.asl index b8a8904..ca9e002 100644 --- a/src/mainboard/lippert/frontrunner-af/acpi/usb.asl +++ b/src/mainboard/lippert/frontrunner-af/acpi/usb.asl @@ -1,14 +1,5 @@ /* SPDX-License-Identifier: GPL-2.0-only */
-/* simple name description */ -/* -#include <acpi/acpi.h> -DefinitionBlock ("DSDT.AML", "DSDT", 0x01, OEM_ID, ACPI_TABLE_CREATOR, 0x00010001 - ) - { - #include "usb.asl" - } -*/ Method(UCOC, 0) { Sleep(20) Store(0x13,CMTI) diff --git a/src/mainboard/lippert/toucan-af/acpi/routing.asl b/src/mainboard/lippert/toucan-af/acpi/routing.asl index 3a5709b..987ba22 100644 --- a/src/mainboard/lippert/toucan-af/acpi/routing.asl +++ b/src/mainboard/lippert/toucan-af/acpi/routing.asl @@ -1,14 +1,5 @@ /* SPDX-License-Identifier: GPL-2.0-only */
-/* -#include <acpi/acpi.h> -DefinitionBlock ("DSDT.AML", "DSDT", 0x01, OEM_ID, ACPI_TABLE_CREATOR, 0x00010001 - ) - { - #include "routing.asl" - } -*/ - /* Routing is in System Bus scope */ Scope(_SB) { Name(PR0, Package(){ diff --git a/src/mainboard/lippert/toucan-af/acpi/usb.asl b/src/mainboard/lippert/toucan-af/acpi/usb.asl index b8a8904..ca9e002 100644 --- a/src/mainboard/lippert/toucan-af/acpi/usb.asl +++ b/src/mainboard/lippert/toucan-af/acpi/usb.asl @@ -1,14 +1,5 @@ /* SPDX-License-Identifier: GPL-2.0-only */
-/* simple name description */ -/* -#include <acpi/acpi.h> -DefinitionBlock ("DSDT.AML", "DSDT", 0x01, OEM_ID, ACPI_TABLE_CREATOR, 0x00010001 - ) - { - #include "usb.asl" - } -*/ Method(UCOC, 0) { Sleep(20) Store(0x13,CMTI) diff --git a/src/mainboard/msi/ms7721/acpi/cpstate.asl b/src/mainboard/msi/ms7721/acpi/cpstate.asl index 2a0372e..494fc73 100644 --- a/src/mainboard/msi/ms7721/acpi/cpstate.asl +++ b/src/mainboard/msi/ms7721/acpi/cpstate.asl @@ -5,33 +5,6 @@ * core. It assumes that each core of the system has the same performance * characteristics. */ -/* -#include <acpi/acpi.h> -DefinitionBlock ("DSDT.AML", "DSDT", 0x01, OEM_ID, ACPI_TABLE_CREATOR, 0x00010001) - { - Scope (_SB) { - Device (CPU0) { - Name (_HID, "ACPI0007") - Name (_UID, 0) - #include "cpstate.asl" - } - Device (CPU1) { - Name (_HID, "ACPI0007") - Name (_UID, 1) - #include "cpstate.asl" - } - Device (CPU2) { - Name (_HID, "ACPI0007") - Name (_UID, 2) - #include "cpstate.asl" - } - Device (CPU3) { - Name (_HID, "ACPI0007") - Name (_UID, 3) - #include "cpstate.asl" - } - } -*/ /* P-state support: The maximum number of P-states supported by the */ /* CPUs we'll use is 6. */ /* Get from AMI BIOS. */ diff --git a/src/mainboard/pcengines/apu1/acpi/routing.asl b/src/mainboard/pcengines/apu1/acpi/routing.asl index af4d709..deef1ec 100644 --- a/src/mainboard/pcengines/apu1/acpi/routing.asl +++ b/src/mainboard/pcengines/apu1/acpi/routing.asl @@ -1,14 +1,5 @@ /* SPDX-License-Identifier: GPL-2.0-only */
-/* -#include <acpi/acpi.h> -DefinitionBlock ("DSDT.AML", "DSDT", 0x01, OEM_ID, ACPI_TABLE_CREATOR, 0x00010001 - ) - { - #include "routing.asl" - } -*/ - /* Routing is in System Bus scope */ Scope(_SB) { Name(PR0, Package(){ diff --git a/src/mainboard/pcengines/apu1/acpi/usb_oc.asl b/src/mainboard/pcengines/apu1/acpi/usb_oc.asl index 63df0ef..4ecc52a 100644 --- a/src/mainboard/pcengines/apu1/acpi/usb_oc.asl +++ b/src/mainboard/pcengines/apu1/acpi/usb_oc.asl @@ -1,15 +1,5 @@ /* SPDX-License-Identifier: GPL-2.0-only */
-/* simple name description */ -/* -#include <acpi/acpi.h> -DefinitionBlock ("DSDT.AML", "DSDT", 0x01, OEM_ID, ACPI_TABLE_CREATOR, 0x00010001 - ) - { - #include "usb.asl" - } -*/ - /* USB overcurrent mapping pins. */ Name(UOM0, 0) Name(UOM1, 2) diff --git a/src/mainboard/pcengines/apu2/acpi/routing.asl b/src/mainboard/pcengines/apu2/acpi/routing.asl index d08e162..106259d 100644 --- a/src/mainboard/pcengines/apu2/acpi/routing.asl +++ b/src/mainboard/pcengines/apu2/acpi/routing.asl @@ -1,14 +1,5 @@ /* SPDX-License-Identifier: GPL-2.0-only */
-/* -#include <acpi/acpi.h> -DefinitionBlock ("DSDT.AML", "DSDT", 0x01, OEM_ID, ACPI_TABLE_CREATOR, 0x00010001 - ) - { - #include "routing.asl" - } -*/ - /* Routing is in System Bus scope */ Name(PR0, Package(){ /* NB devices */ diff --git a/src/mainboard/pcengines/apu2/acpi/usb_oc.asl b/src/mainboard/pcengines/apu2/acpi/usb_oc.asl index 52b2daa..a5846fe 100644 --- a/src/mainboard/pcengines/apu2/acpi/usb_oc.asl +++ b/src/mainboard/pcengines/apu2/acpi/usb_oc.asl @@ -1,15 +1,5 @@ /* SPDX-License-Identifier: GPL-2.0-only */
-/* simple name description */ -/* -#include <acpi/acpi.h> -DefinitionBlock ("DSDT.AML", "DSDT", 0x01, OEM_ID, ACPI_TABLE_CREATOR, 0x00010001 - ) - { - #include "usb.asl" - } -*/ - /* USB overcurrent mapping pins. */ Name(UOM0, 0) Name(UOM1, 2)
Michael Niewöhner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43270 )
Change subject: ACPI: Drop commented-out DSDT DefinitionBlock instances ......................................................................
Patch Set 2: Code-Review+2
Angel Pons has submitted this change. ( https://review.coreboot.org/c/coreboot/+/43270 )
Change subject: ACPI: Drop commented-out DSDT DefinitionBlock instances ......................................................................
ACPI: Drop commented-out DSDT DefinitionBlock instances
This code is not even being build-tested. Drop it before it grows moss.
Change-Id: I9b5589d4596eead83a5897b083ccb85ef05a03d5 Signed-off-by: Angel Pons th3fanbus@gmail.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/43270 Reviewed-by: Michael Niewöhner Tested-by: build bot (Jenkins) no-reply@coreboot.org --- M src/arch/x86/acpi/debug.asl M src/mainboard/amd/gardenia/acpi/routing.asl M src/mainboard/amd/gardenia/acpi/usb_oc.asl M src/mainboard/amd/inagua/acpi/routing.asl M src/mainboard/amd/inagua/acpi/usb_oc.asl M src/mainboard/amd/olivehill/acpi/routing.asl M src/mainboard/amd/persimmon/acpi/routing.asl M src/mainboard/amd/persimmon/acpi/usb_oc.asl M src/mainboard/amd/south_station/acpi/routing.asl M src/mainboard/amd/south_station/acpi/usb_oc.asl M src/mainboard/amd/thatcher/acpi/cpstate.asl M src/mainboard/amd/union_station/acpi/routing.asl M src/mainboard/amd/union_station/acpi/usb_oc.asl M src/mainboard/asrock/e350m1/acpi/routing.asl M src/mainboard/asrock/e350m1/acpi/usb_oc.asl M src/mainboard/asrock/imb-a180/acpi/routing.asl M src/mainboard/asus/f2a85-m/acpi/cpstate.asl M src/mainboard/bap/ode_e20XX/acpi/routing.asl M src/mainboard/biostar/a68n_5200/acpi/routing.asl M src/mainboard/biostar/am1ml/acpi/routing.asl M src/mainboard/elmex/pcm205400/acpi/routing.asl M src/mainboard/elmex/pcm205400/acpi/usb_oc.asl M src/mainboard/gizmosphere/gizmo/acpi/routing.asl M src/mainboard/gizmosphere/gizmo/acpi/usb_oc.asl M src/mainboard/gizmosphere/gizmo2/acpi/routing.asl M src/mainboard/google/kahlee/variants/baseboard/include/baseboard/acpi/routing.asl M src/mainboard/hp/abm/acpi/routing.asl M src/mainboard/jetway/nf81-t56n-lf/acpi/routing.asl M src/mainboard/jetway/nf81-t56n-lf/acpi/usb_oc.asl M src/mainboard/lippert/frontrunner-af/acpi/routing.asl M src/mainboard/lippert/frontrunner-af/acpi/usb.asl M src/mainboard/lippert/toucan-af/acpi/routing.asl M src/mainboard/lippert/toucan-af/acpi/usb.asl M src/mainboard/msi/ms7721/acpi/cpstate.asl M src/mainboard/pcengines/apu1/acpi/routing.asl M src/mainboard/pcengines/apu1/acpi/usb_oc.asl M src/mainboard/pcengines/apu2/acpi/routing.asl M src/mainboard/pcengines/apu2/acpi/usb_oc.asl 38 files changed, 0 insertions(+), 412 deletions(-)
Approvals: build bot (Jenkins): Verified Michael Niewöhner: Looks good to me, approved
diff --git a/src/arch/x86/acpi/debug.asl b/src/arch/x86/acpi/debug.asl index 11651e4..fd071f8 100644 --- a/src/arch/x86/acpi/debug.asl +++ b/src/arch/x86/acpi/debug.asl @@ -1,21 +1,6 @@ /* SPDX-License-Identifier: GPL-2.0-only */
/* - #include <acpi/acpi.h> - DefinitionBlock ( - "DSDT.AML", - "DSDT", - 0x01, - OEM_ID, - ACPI_TABLE_CREATOR, - 0x00010001 - ) - { - #include "debug.asl" - } -*/ - -/* * 0x80: POST_BASE * 0x3F8: DEBCOM_BASE * X80: POST_REGION diff --git a/src/mainboard/amd/gardenia/acpi/routing.asl b/src/mainboard/amd/gardenia/acpi/routing.asl index 3e7d6e6..d4d1c4a 100644 --- a/src/mainboard/amd/gardenia/acpi/routing.asl +++ b/src/mainboard/amd/gardenia/acpi/routing.asl @@ -1,14 +1,5 @@ /* SPDX-License-Identifier: GPL-2.0-only */
-/* -#include <acpi/acpi.h> -DefinitionBlock ("DSDT.AML", "DSDT", 0x01, OEM_ID, ACPI_TABLE_CREATOR, 0x00010001 - ) - { - #include "routing.asl" - } -*/ - /* Routing is in System Bus scope */ Name(PR0, Package(){ /* NB devices */ diff --git a/src/mainboard/amd/gardenia/acpi/usb_oc.asl b/src/mainboard/amd/gardenia/acpi/usb_oc.asl index 4b7719c..b1e2210 100644 --- a/src/mainboard/amd/gardenia/acpi/usb_oc.asl +++ b/src/mainboard/amd/gardenia/acpi/usb_oc.asl @@ -1,15 +1,5 @@ /* SPDX-License-Identifier: GPL-2.0-only */
-/* simple name description */ -/* -#include <acpi/acpi.h> -DefinitionBlock ("DSDT.AML", "DSDT", 0x01, OEM_ID, ACPI_TABLE_CREATOR, 0x00010001 - ) - { - #include "usb.asl" - } -*/ - /* USB overcurrent mapping pins. */ Name(UOM0, 0) Name(UOM1, 2) diff --git a/src/mainboard/amd/inagua/acpi/routing.asl b/src/mainboard/amd/inagua/acpi/routing.asl index 7481f1d..2b5823f 100644 --- a/src/mainboard/amd/inagua/acpi/routing.asl +++ b/src/mainboard/amd/inagua/acpi/routing.asl @@ -1,14 +1,5 @@ /* SPDX-License-Identifier: GPL-2.0-only */
-/* -#include <acpi/acpi.h> -DefinitionBlock ("DSDT.AML", "DSDT", 0x01, OEM_ID, ACPI_TABLE_CREATOR, 0x00010001 - ) - { - #include "routing.asl" - } -*/ - /* Routing is in System Bus scope */ Scope(_SB) { Name(PR0, Package(){ diff --git a/src/mainboard/amd/inagua/acpi/usb_oc.asl b/src/mainboard/amd/inagua/acpi/usb_oc.asl index 63df0ef..4ecc52a 100644 --- a/src/mainboard/amd/inagua/acpi/usb_oc.asl +++ b/src/mainboard/amd/inagua/acpi/usb_oc.asl @@ -1,15 +1,5 @@ /* SPDX-License-Identifier: GPL-2.0-only */
-/* simple name description */ -/* -#include <acpi/acpi.h> -DefinitionBlock ("DSDT.AML", "DSDT", 0x01, OEM_ID, ACPI_TABLE_CREATOR, 0x00010001 - ) - { - #include "usb.asl" - } -*/ - /* USB overcurrent mapping pins. */ Name(UOM0, 0) Name(UOM1, 2) diff --git a/src/mainboard/amd/olivehill/acpi/routing.asl b/src/mainboard/amd/olivehill/acpi/routing.asl index d08e162..106259d 100644 --- a/src/mainboard/amd/olivehill/acpi/routing.asl +++ b/src/mainboard/amd/olivehill/acpi/routing.asl @@ -1,14 +1,5 @@ /* SPDX-License-Identifier: GPL-2.0-only */
-/* -#include <acpi/acpi.h> -DefinitionBlock ("DSDT.AML", "DSDT", 0x01, OEM_ID, ACPI_TABLE_CREATOR, 0x00010001 - ) - { - #include "routing.asl" - } -*/ - /* Routing is in System Bus scope */ Name(PR0, Package(){ /* NB devices */ diff --git a/src/mainboard/amd/persimmon/acpi/routing.asl b/src/mainboard/amd/persimmon/acpi/routing.asl index d039a7a..656a0be 100644 --- a/src/mainboard/amd/persimmon/acpi/routing.asl +++ b/src/mainboard/amd/persimmon/acpi/routing.asl @@ -1,14 +1,5 @@ /* SPDX-License-Identifier: GPL-2.0-only */
-/* -#include <acpi/acpi.h> -DefinitionBlock ("DSDT.AML", "DSDT", 0x01, OEM_ID, ACPI_TABLE_CREATOR, 0x00010001 - ) - { - #include "routing.asl" - } -*/ - /* Routing is in System Bus scope */ Scope(_SB) { Name(PR0, Package(){ diff --git a/src/mainboard/amd/persimmon/acpi/usb_oc.asl b/src/mainboard/amd/persimmon/acpi/usb_oc.asl index 63df0ef..4ecc52a 100644 --- a/src/mainboard/amd/persimmon/acpi/usb_oc.asl +++ b/src/mainboard/amd/persimmon/acpi/usb_oc.asl @@ -1,15 +1,5 @@ /* SPDX-License-Identifier: GPL-2.0-only */
-/* simple name description */ -/* -#include <acpi/acpi.h> -DefinitionBlock ("DSDT.AML", "DSDT", 0x01, OEM_ID, ACPI_TABLE_CREATOR, 0x00010001 - ) - { - #include "usb.asl" - } -*/ - /* USB overcurrent mapping pins. */ Name(UOM0, 0) Name(UOM1, 2) diff --git a/src/mainboard/amd/south_station/acpi/routing.asl b/src/mainboard/amd/south_station/acpi/routing.asl index 7481f1d..2b5823f 100644 --- a/src/mainboard/amd/south_station/acpi/routing.asl +++ b/src/mainboard/amd/south_station/acpi/routing.asl @@ -1,14 +1,5 @@ /* SPDX-License-Identifier: GPL-2.0-only */
-/* -#include <acpi/acpi.h> -DefinitionBlock ("DSDT.AML", "DSDT", 0x01, OEM_ID, ACPI_TABLE_CREATOR, 0x00010001 - ) - { - #include "routing.asl" - } -*/ - /* Routing is in System Bus scope */ Scope(_SB) { Name(PR0, Package(){ diff --git a/src/mainboard/amd/south_station/acpi/usb_oc.asl b/src/mainboard/amd/south_station/acpi/usb_oc.asl index 63df0ef..4ecc52a 100644 --- a/src/mainboard/amd/south_station/acpi/usb_oc.asl +++ b/src/mainboard/amd/south_station/acpi/usb_oc.asl @@ -1,15 +1,5 @@ /* SPDX-License-Identifier: GPL-2.0-only */
-/* simple name description */ -/* -#include <acpi/acpi.h> -DefinitionBlock ("DSDT.AML", "DSDT", 0x01, OEM_ID, ACPI_TABLE_CREATOR, 0x00010001 - ) - { - #include "usb.asl" - } -*/ - /* USB overcurrent mapping pins. */ Name(UOM0, 0) Name(UOM1, 2) diff --git a/src/mainboard/amd/thatcher/acpi/cpstate.asl b/src/mainboard/amd/thatcher/acpi/cpstate.asl index 2a0372e..494fc73 100644 --- a/src/mainboard/amd/thatcher/acpi/cpstate.asl +++ b/src/mainboard/amd/thatcher/acpi/cpstate.asl @@ -5,33 +5,6 @@ * core. It assumes that each core of the system has the same performance * characteristics. */ -/* -#include <acpi/acpi.h> -DefinitionBlock ("DSDT.AML", "DSDT", 0x01, OEM_ID, ACPI_TABLE_CREATOR, 0x00010001) - { - Scope (_SB) { - Device (CPU0) { - Name (_HID, "ACPI0007") - Name (_UID, 0) - #include "cpstate.asl" - } - Device (CPU1) { - Name (_HID, "ACPI0007") - Name (_UID, 1) - #include "cpstate.asl" - } - Device (CPU2) { - Name (_HID, "ACPI0007") - Name (_UID, 2) - #include "cpstate.asl" - } - Device (CPU3) { - Name (_HID, "ACPI0007") - Name (_UID, 3) - #include "cpstate.asl" - } - } -*/ /* P-state support: The maximum number of P-states supported by the */ /* CPUs we'll use is 6. */ /* Get from AMI BIOS. */ diff --git a/src/mainboard/amd/union_station/acpi/routing.asl b/src/mainboard/amd/union_station/acpi/routing.asl index 7481f1d..2b5823f 100644 --- a/src/mainboard/amd/union_station/acpi/routing.asl +++ b/src/mainboard/amd/union_station/acpi/routing.asl @@ -1,14 +1,5 @@ /* SPDX-License-Identifier: GPL-2.0-only */
-/* -#include <acpi/acpi.h> -DefinitionBlock ("DSDT.AML", "DSDT", 0x01, OEM_ID, ACPI_TABLE_CREATOR, 0x00010001 - ) - { - #include "routing.asl" - } -*/ - /* Routing is in System Bus scope */ Scope(_SB) { Name(PR0, Package(){ diff --git a/src/mainboard/amd/union_station/acpi/usb_oc.asl b/src/mainboard/amd/union_station/acpi/usb_oc.asl index 63df0ef..4ecc52a 100644 --- a/src/mainboard/amd/union_station/acpi/usb_oc.asl +++ b/src/mainboard/amd/union_station/acpi/usb_oc.asl @@ -1,15 +1,5 @@ /* SPDX-License-Identifier: GPL-2.0-only */
-/* simple name description */ -/* -#include <acpi/acpi.h> -DefinitionBlock ("DSDT.AML", "DSDT", 0x01, OEM_ID, ACPI_TABLE_CREATOR, 0x00010001 - ) - { - #include "usb.asl" - } -*/ - /* USB overcurrent mapping pins. */ Name(UOM0, 0) Name(UOM1, 2) diff --git a/src/mainboard/asrock/e350m1/acpi/routing.asl b/src/mainboard/asrock/e350m1/acpi/routing.asl index 8ea04e1..5fa77f0 100644 --- a/src/mainboard/asrock/e350m1/acpi/routing.asl +++ b/src/mainboard/asrock/e350m1/acpi/routing.asl @@ -1,14 +1,5 @@ /* SPDX-License-Identifier: GPL-2.0-only */
-/* -#include <acpi/acpi.h> -DefinitionBlock ("DSDT.AML", "DSDT", 0x01, OEM_ID, ACPI_TABLE_CREATOR, 0x00010001 - ) - { - #include "routing.asl" - } -*/ - /* Routing is in System Bus scope */ Scope(_SB) { Name(PR0, Package(){ diff --git a/src/mainboard/asrock/e350m1/acpi/usb_oc.asl b/src/mainboard/asrock/e350m1/acpi/usb_oc.asl index 63df0ef..4ecc52a 100644 --- a/src/mainboard/asrock/e350m1/acpi/usb_oc.asl +++ b/src/mainboard/asrock/e350m1/acpi/usb_oc.asl @@ -1,15 +1,5 @@ /* SPDX-License-Identifier: GPL-2.0-only */
-/* simple name description */ -/* -#include <acpi/acpi.h> -DefinitionBlock ("DSDT.AML", "DSDT", 0x01, OEM_ID, ACPI_TABLE_CREATOR, 0x00010001 - ) - { - #include "usb.asl" - } -*/ - /* USB overcurrent mapping pins. */ Name(UOM0, 0) Name(UOM1, 2) diff --git a/src/mainboard/asrock/imb-a180/acpi/routing.asl b/src/mainboard/asrock/imb-a180/acpi/routing.asl index d08e162..106259d 100644 --- a/src/mainboard/asrock/imb-a180/acpi/routing.asl +++ b/src/mainboard/asrock/imb-a180/acpi/routing.asl @@ -1,14 +1,5 @@ /* SPDX-License-Identifier: GPL-2.0-only */
-/* -#include <acpi/acpi.h> -DefinitionBlock ("DSDT.AML", "DSDT", 0x01, OEM_ID, ACPI_TABLE_CREATOR, 0x00010001 - ) - { - #include "routing.asl" - } -*/ - /* Routing is in System Bus scope */ Name(PR0, Package(){ /* NB devices */ diff --git a/src/mainboard/asus/f2a85-m/acpi/cpstate.asl b/src/mainboard/asus/f2a85-m/acpi/cpstate.asl index 2a0372e..494fc73 100644 --- a/src/mainboard/asus/f2a85-m/acpi/cpstate.asl +++ b/src/mainboard/asus/f2a85-m/acpi/cpstate.asl @@ -5,33 +5,6 @@ * core. It assumes that each core of the system has the same performance * characteristics. */ -/* -#include <acpi/acpi.h> -DefinitionBlock ("DSDT.AML", "DSDT", 0x01, OEM_ID, ACPI_TABLE_CREATOR, 0x00010001) - { - Scope (_SB) { - Device (CPU0) { - Name (_HID, "ACPI0007") - Name (_UID, 0) - #include "cpstate.asl" - } - Device (CPU1) { - Name (_HID, "ACPI0007") - Name (_UID, 1) - #include "cpstate.asl" - } - Device (CPU2) { - Name (_HID, "ACPI0007") - Name (_UID, 2) - #include "cpstate.asl" - } - Device (CPU3) { - Name (_HID, "ACPI0007") - Name (_UID, 3) - #include "cpstate.asl" - } - } -*/ /* P-state support: The maximum number of P-states supported by the */ /* CPUs we'll use is 6. */ /* Get from AMI BIOS. */ diff --git a/src/mainboard/bap/ode_e20XX/acpi/routing.asl b/src/mainboard/bap/ode_e20XX/acpi/routing.asl index d08e162..106259d 100644 --- a/src/mainboard/bap/ode_e20XX/acpi/routing.asl +++ b/src/mainboard/bap/ode_e20XX/acpi/routing.asl @@ -1,14 +1,5 @@ /* SPDX-License-Identifier: GPL-2.0-only */
-/* -#include <acpi/acpi.h> -DefinitionBlock ("DSDT.AML", "DSDT", 0x01, OEM_ID, ACPI_TABLE_CREATOR, 0x00010001 - ) - { - #include "routing.asl" - } -*/ - /* Routing is in System Bus scope */ Name(PR0, Package(){ /* NB devices */ diff --git a/src/mainboard/biostar/a68n_5200/acpi/routing.asl b/src/mainboard/biostar/a68n_5200/acpi/routing.asl index d08e162..106259d 100644 --- a/src/mainboard/biostar/a68n_5200/acpi/routing.asl +++ b/src/mainboard/biostar/a68n_5200/acpi/routing.asl @@ -1,14 +1,5 @@ /* SPDX-License-Identifier: GPL-2.0-only */
-/* -#include <acpi/acpi.h> -DefinitionBlock ("DSDT.AML", "DSDT", 0x01, OEM_ID, ACPI_TABLE_CREATOR, 0x00010001 - ) - { - #include "routing.asl" - } -*/ - /* Routing is in System Bus scope */ Name(PR0, Package(){ /* NB devices */ diff --git a/src/mainboard/biostar/am1ml/acpi/routing.asl b/src/mainboard/biostar/am1ml/acpi/routing.asl index d08e162..106259d 100644 --- a/src/mainboard/biostar/am1ml/acpi/routing.asl +++ b/src/mainboard/biostar/am1ml/acpi/routing.asl @@ -1,14 +1,5 @@ /* SPDX-License-Identifier: GPL-2.0-only */
-/* -#include <acpi/acpi.h> -DefinitionBlock ("DSDT.AML", "DSDT", 0x01, OEM_ID, ACPI_TABLE_CREATOR, 0x00010001 - ) - { - #include "routing.asl" - } -*/ - /* Routing is in System Bus scope */ Name(PR0, Package(){ /* NB devices */ diff --git a/src/mainboard/elmex/pcm205400/acpi/routing.asl b/src/mainboard/elmex/pcm205400/acpi/routing.asl index d039a7a..656a0be 100644 --- a/src/mainboard/elmex/pcm205400/acpi/routing.asl +++ b/src/mainboard/elmex/pcm205400/acpi/routing.asl @@ -1,14 +1,5 @@ /* SPDX-License-Identifier: GPL-2.0-only */
-/* -#include <acpi/acpi.h> -DefinitionBlock ("DSDT.AML", "DSDT", 0x01, OEM_ID, ACPI_TABLE_CREATOR, 0x00010001 - ) - { - #include "routing.asl" - } -*/ - /* Routing is in System Bus scope */ Scope(_SB) { Name(PR0, Package(){ diff --git a/src/mainboard/elmex/pcm205400/acpi/usb_oc.asl b/src/mainboard/elmex/pcm205400/acpi/usb_oc.asl index 63df0ef..4ecc52a 100644 --- a/src/mainboard/elmex/pcm205400/acpi/usb_oc.asl +++ b/src/mainboard/elmex/pcm205400/acpi/usb_oc.asl @@ -1,15 +1,5 @@ /* SPDX-License-Identifier: GPL-2.0-only */
-/* simple name description */ -/* -#include <acpi/acpi.h> -DefinitionBlock ("DSDT.AML", "DSDT", 0x01, OEM_ID, ACPI_TABLE_CREATOR, 0x00010001 - ) - { - #include "usb.asl" - } -*/ - /* USB overcurrent mapping pins. */ Name(UOM0, 0) Name(UOM1, 2) diff --git a/src/mainboard/gizmosphere/gizmo/acpi/routing.asl b/src/mainboard/gizmosphere/gizmo/acpi/routing.asl index 8ea04e1..5fa77f0 100644 --- a/src/mainboard/gizmosphere/gizmo/acpi/routing.asl +++ b/src/mainboard/gizmosphere/gizmo/acpi/routing.asl @@ -1,14 +1,5 @@ /* SPDX-License-Identifier: GPL-2.0-only */
-/* -#include <acpi/acpi.h> -DefinitionBlock ("DSDT.AML", "DSDT", 0x01, OEM_ID, ACPI_TABLE_CREATOR, 0x00010001 - ) - { - #include "routing.asl" - } -*/ - /* Routing is in System Bus scope */ Scope(_SB) { Name(PR0, Package(){ diff --git a/src/mainboard/gizmosphere/gizmo/acpi/usb_oc.asl b/src/mainboard/gizmosphere/gizmo/acpi/usb_oc.asl index 63df0ef..4ecc52a 100644 --- a/src/mainboard/gizmosphere/gizmo/acpi/usb_oc.asl +++ b/src/mainboard/gizmosphere/gizmo/acpi/usb_oc.asl @@ -1,15 +1,5 @@ /* SPDX-License-Identifier: GPL-2.0-only */
-/* simple name description */ -/* -#include <acpi/acpi.h> -DefinitionBlock ("DSDT.AML", "DSDT", 0x01, OEM_ID, ACPI_TABLE_CREATOR, 0x00010001 - ) - { - #include "usb.asl" - } -*/ - /* USB overcurrent mapping pins. */ Name(UOM0, 0) Name(UOM1, 2) diff --git a/src/mainboard/gizmosphere/gizmo2/acpi/routing.asl b/src/mainboard/gizmosphere/gizmo2/acpi/routing.asl index d08e162..106259d 100644 --- a/src/mainboard/gizmosphere/gizmo2/acpi/routing.asl +++ b/src/mainboard/gizmosphere/gizmo2/acpi/routing.asl @@ -1,14 +1,5 @@ /* SPDX-License-Identifier: GPL-2.0-only */
-/* -#include <acpi/acpi.h> -DefinitionBlock ("DSDT.AML", "DSDT", 0x01, OEM_ID, ACPI_TABLE_CREATOR, 0x00010001 - ) - { - #include "routing.asl" - } -*/ - /* Routing is in System Bus scope */ Name(PR0, Package(){ /* NB devices */ diff --git a/src/mainboard/google/kahlee/variants/baseboard/include/baseboard/acpi/routing.asl b/src/mainboard/google/kahlee/variants/baseboard/include/baseboard/acpi/routing.asl index fcf3958..72996ce 100644 --- a/src/mainboard/google/kahlee/variants/baseboard/include/baseboard/acpi/routing.asl +++ b/src/mainboard/google/kahlee/variants/baseboard/include/baseboard/acpi/routing.asl @@ -1,13 +1,5 @@ /* SPDX-License-Identifier: GPL-2.0-only */
-/* - * #include <acpi/acpi.h> -DefinitionBlock ("DSDT.AML", "DSDT", 0x01, OEM_ID, ACPI_TABLE_CREATOR, 0x00010001) - *{ - * #include "routing.asl" - *} - */ - /* Routing is in System Bus scope */ Name (PR0, Package() { diff --git a/src/mainboard/hp/abm/acpi/routing.asl b/src/mainboard/hp/abm/acpi/routing.asl index d08e162..106259d 100644 --- a/src/mainboard/hp/abm/acpi/routing.asl +++ b/src/mainboard/hp/abm/acpi/routing.asl @@ -1,14 +1,5 @@ /* SPDX-License-Identifier: GPL-2.0-only */
-/* -#include <acpi/acpi.h> -DefinitionBlock ("DSDT.AML", "DSDT", 0x01, OEM_ID, ACPI_TABLE_CREATOR, 0x00010001 - ) - { - #include "routing.asl" - } -*/ - /* Routing is in System Bus scope */ Name(PR0, Package(){ /* NB devices */ diff --git a/src/mainboard/jetway/nf81-t56n-lf/acpi/routing.asl b/src/mainboard/jetway/nf81-t56n-lf/acpi/routing.asl index d039a7a..656a0be 100644 --- a/src/mainboard/jetway/nf81-t56n-lf/acpi/routing.asl +++ b/src/mainboard/jetway/nf81-t56n-lf/acpi/routing.asl @@ -1,14 +1,5 @@ /* SPDX-License-Identifier: GPL-2.0-only */
-/* -#include <acpi/acpi.h> -DefinitionBlock ("DSDT.AML", "DSDT", 0x01, OEM_ID, ACPI_TABLE_CREATOR, 0x00010001 - ) - { - #include "routing.asl" - } -*/ - /* Routing is in System Bus scope */ Scope(_SB) { Name(PR0, Package(){ diff --git a/src/mainboard/jetway/nf81-t56n-lf/acpi/usb_oc.asl b/src/mainboard/jetway/nf81-t56n-lf/acpi/usb_oc.asl index 63df0ef..4ecc52a 100644 --- a/src/mainboard/jetway/nf81-t56n-lf/acpi/usb_oc.asl +++ b/src/mainboard/jetway/nf81-t56n-lf/acpi/usb_oc.asl @@ -1,15 +1,5 @@ /* SPDX-License-Identifier: GPL-2.0-only */
-/* simple name description */ -/* -#include <acpi/acpi.h> -DefinitionBlock ("DSDT.AML", "DSDT", 0x01, OEM_ID, ACPI_TABLE_CREATOR, 0x00010001 - ) - { - #include "usb.asl" - } -*/ - /* USB overcurrent mapping pins. */ Name(UOM0, 0) Name(UOM1, 2) diff --git a/src/mainboard/lippert/frontrunner-af/acpi/routing.asl b/src/mainboard/lippert/frontrunner-af/acpi/routing.asl index d2e9d4a..7b73e5d 100644 --- a/src/mainboard/lippert/frontrunner-af/acpi/routing.asl +++ b/src/mainboard/lippert/frontrunner-af/acpi/routing.asl @@ -1,14 +1,5 @@ /* SPDX-License-Identifier: GPL-2.0-only */
-/* -#include <acpi/acpi.h> -DefinitionBlock ("DSDT.AML", "DSDT", 0x01, OEM_ID, ACPI_TABLE_CREATOR, 0x00010001 - ) - { - #include "routing.asl" - } -*/ - /* Routing is in System Bus scope */ Scope(_SB) { Name(PR0, Package(){ diff --git a/src/mainboard/lippert/frontrunner-af/acpi/usb.asl b/src/mainboard/lippert/frontrunner-af/acpi/usb.asl index b8a8904..ca9e002 100644 --- a/src/mainboard/lippert/frontrunner-af/acpi/usb.asl +++ b/src/mainboard/lippert/frontrunner-af/acpi/usb.asl @@ -1,14 +1,5 @@ /* SPDX-License-Identifier: GPL-2.0-only */
-/* simple name description */ -/* -#include <acpi/acpi.h> -DefinitionBlock ("DSDT.AML", "DSDT", 0x01, OEM_ID, ACPI_TABLE_CREATOR, 0x00010001 - ) - { - #include "usb.asl" - } -*/ Method(UCOC, 0) { Sleep(20) Store(0x13,CMTI) diff --git a/src/mainboard/lippert/toucan-af/acpi/routing.asl b/src/mainboard/lippert/toucan-af/acpi/routing.asl index 3a5709b..987ba22 100644 --- a/src/mainboard/lippert/toucan-af/acpi/routing.asl +++ b/src/mainboard/lippert/toucan-af/acpi/routing.asl @@ -1,14 +1,5 @@ /* SPDX-License-Identifier: GPL-2.0-only */
-/* -#include <acpi/acpi.h> -DefinitionBlock ("DSDT.AML", "DSDT", 0x01, OEM_ID, ACPI_TABLE_CREATOR, 0x00010001 - ) - { - #include "routing.asl" - } -*/ - /* Routing is in System Bus scope */ Scope(_SB) { Name(PR0, Package(){ diff --git a/src/mainboard/lippert/toucan-af/acpi/usb.asl b/src/mainboard/lippert/toucan-af/acpi/usb.asl index b8a8904..ca9e002 100644 --- a/src/mainboard/lippert/toucan-af/acpi/usb.asl +++ b/src/mainboard/lippert/toucan-af/acpi/usb.asl @@ -1,14 +1,5 @@ /* SPDX-License-Identifier: GPL-2.0-only */
-/* simple name description */ -/* -#include <acpi/acpi.h> -DefinitionBlock ("DSDT.AML", "DSDT", 0x01, OEM_ID, ACPI_TABLE_CREATOR, 0x00010001 - ) - { - #include "usb.asl" - } -*/ Method(UCOC, 0) { Sleep(20) Store(0x13,CMTI) diff --git a/src/mainboard/msi/ms7721/acpi/cpstate.asl b/src/mainboard/msi/ms7721/acpi/cpstate.asl index 2a0372e..494fc73 100644 --- a/src/mainboard/msi/ms7721/acpi/cpstate.asl +++ b/src/mainboard/msi/ms7721/acpi/cpstate.asl @@ -5,33 +5,6 @@ * core. It assumes that each core of the system has the same performance * characteristics. */ -/* -#include <acpi/acpi.h> -DefinitionBlock ("DSDT.AML", "DSDT", 0x01, OEM_ID, ACPI_TABLE_CREATOR, 0x00010001) - { - Scope (_SB) { - Device (CPU0) { - Name (_HID, "ACPI0007") - Name (_UID, 0) - #include "cpstate.asl" - } - Device (CPU1) { - Name (_HID, "ACPI0007") - Name (_UID, 1) - #include "cpstate.asl" - } - Device (CPU2) { - Name (_HID, "ACPI0007") - Name (_UID, 2) - #include "cpstate.asl" - } - Device (CPU3) { - Name (_HID, "ACPI0007") - Name (_UID, 3) - #include "cpstate.asl" - } - } -*/ /* P-state support: The maximum number of P-states supported by the */ /* CPUs we'll use is 6. */ /* Get from AMI BIOS. */ diff --git a/src/mainboard/pcengines/apu1/acpi/routing.asl b/src/mainboard/pcengines/apu1/acpi/routing.asl index af4d709..deef1ec 100644 --- a/src/mainboard/pcengines/apu1/acpi/routing.asl +++ b/src/mainboard/pcengines/apu1/acpi/routing.asl @@ -1,14 +1,5 @@ /* SPDX-License-Identifier: GPL-2.0-only */
-/* -#include <acpi/acpi.h> -DefinitionBlock ("DSDT.AML", "DSDT", 0x01, OEM_ID, ACPI_TABLE_CREATOR, 0x00010001 - ) - { - #include "routing.asl" - } -*/ - /* Routing is in System Bus scope */ Scope(_SB) { Name(PR0, Package(){ diff --git a/src/mainboard/pcengines/apu1/acpi/usb_oc.asl b/src/mainboard/pcengines/apu1/acpi/usb_oc.asl index 63df0ef..4ecc52a 100644 --- a/src/mainboard/pcengines/apu1/acpi/usb_oc.asl +++ b/src/mainboard/pcengines/apu1/acpi/usb_oc.asl @@ -1,15 +1,5 @@ /* SPDX-License-Identifier: GPL-2.0-only */
-/* simple name description */ -/* -#include <acpi/acpi.h> -DefinitionBlock ("DSDT.AML", "DSDT", 0x01, OEM_ID, ACPI_TABLE_CREATOR, 0x00010001 - ) - { - #include "usb.asl" - } -*/ - /* USB overcurrent mapping pins. */ Name(UOM0, 0) Name(UOM1, 2) diff --git a/src/mainboard/pcengines/apu2/acpi/routing.asl b/src/mainboard/pcengines/apu2/acpi/routing.asl index d08e162..106259d 100644 --- a/src/mainboard/pcengines/apu2/acpi/routing.asl +++ b/src/mainboard/pcengines/apu2/acpi/routing.asl @@ -1,14 +1,5 @@ /* SPDX-License-Identifier: GPL-2.0-only */
-/* -#include <acpi/acpi.h> -DefinitionBlock ("DSDT.AML", "DSDT", 0x01, OEM_ID, ACPI_TABLE_CREATOR, 0x00010001 - ) - { - #include "routing.asl" - } -*/ - /* Routing is in System Bus scope */ Name(PR0, Package(){ /* NB devices */ diff --git a/src/mainboard/pcengines/apu2/acpi/usb_oc.asl b/src/mainboard/pcengines/apu2/acpi/usb_oc.asl index 52b2daa..a5846fe 100644 --- a/src/mainboard/pcengines/apu2/acpi/usb_oc.asl +++ b/src/mainboard/pcengines/apu2/acpi/usb_oc.asl @@ -1,15 +1,5 @@ /* SPDX-License-Identifier: GPL-2.0-only */
-/* simple name description */ -/* -#include <acpi/acpi.h> -DefinitionBlock ("DSDT.AML", "DSDT", 0x01, OEM_ID, ACPI_TABLE_CREATOR, 0x00010001 - ) - { - #include "usb.asl" - } -*/ - /* USB overcurrent mapping pins. */ Name(UOM0, 0) Name(UOM1, 2)
-
Angel Pons (Code Review) -
Michael Niewöhner (Code Review)