Felix Held has submitted this change. ( https://review.coreboot.org/c/coreboot/+/76074?usp=email )
Change subject: soc/amd/common/block/acpi/ivrs: zero-initialize ivhd_hpet struct ......................................................................
soc/amd/common/block/acpi/ivrs: zero-initialize ivhd_hpet struct
Zero-initialize the ivhd_hpet struct right at the beginning of the ivhd_describe_hpet function to make sure that the whole struct is in a defined state.
Signed-off-by: Felix Held felix-coreboot@felixheld.de Change-Id: If4d3563c485eed4a7cb0526a62f7b6c80f763bfd Reviewed-on: https://review.coreboot.org/c/coreboot/+/76074 Reviewed-by: Jason Glenesk jason.glenesk@gmail.com Reviewed-by: Fred Reitberger reitbergerfred@gmail.com Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Paul Menzel paulepanter@mailbox.org --- M src/soc/amd/common/block/acpi/ivrs.c 1 file changed, 1 insertion(+), 2 deletions(-)
Approvals: Jason Glenesk: Looks good to me, approved build bot (Jenkins): Verified Fred Reitberger: Looks good to me, approved Paul Menzel: Looks good to me, but someone else must approve
diff --git a/src/soc/amd/common/block/acpi/ivrs.c b/src/soc/amd/common/block/acpi/ivrs.c index 7afabf8..d2080e9 100644 --- a/src/soc/amd/common/block/acpi/ivrs.c +++ b/src/soc/amd/common/block/acpi/ivrs.c @@ -36,10 +36,9 @@ static unsigned long ivhd_describe_hpet(unsigned long current, uint8_t hndl, uint16_t src_devid) { ivrs_ivhd_special_t *ivhd_hpet = (ivrs_ivhd_special_t *)current; + memset(ivhd_hpet, 0, sizeof(*ivhd_hpet));
ivhd_hpet->type = IVHD_DEV_8_BYTE_EXT_SPECIAL_DEV; - ivhd_hpet->reserved = 0x0000; - ivhd_hpet->dte_setting = 0x00; ivhd_hpet->handle = hndl; ivhd_hpet->source_dev_id = src_devid; /* function 0 of FCH PCI device */ ivhd_hpet->variety = IVHD_SPECIAL_DEV_HPET;