Attention is currently required from: Sean Rhodes, Martin Roth, Matt DeVillier, Paul Menzel, Tim Wawrzynczak, Angel Pons. build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/58854 )
Change subject: [WIP] util: Add coreboot Configurator ......................................................................
Patch Set 37:
(23 comments)
File util/coreboot-configurator/src/application/configuration.h:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132749): https://review.coreboot.org/c/coreboot/+/58854/comment/4ac1612c_efda71fe PS37, Line 13: using Parameters = QMap < QString,QString >; space required after that ',' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132749): https://review.coreboot.org/c/coreboot/+/58854/comment/ceb93996_2f3ff452 PS37, Line 13: using Parameters = QMap < QString,QString >; spaces required around that '>' (ctx:WxO)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132749): https://review.coreboot.org/c/coreboot/+/58854/comment/903dc62b_b775edc7 PS37, Line 16: bool toFile(const QString & curr_path, const Parameters & params); function definition argument 'const Parameters' should also have an identifier name
File util/coreboot-configurator/src/application/nvramtoolcli.h:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132749): https://review.coreboot.org/c/coreboot/+/58854/comment/6757df3f_0236ff1f PS37, Line 19: bool writeParameters(const Configuration::Parameters & parameters, function definition argument 'Parameters' should also have an identifier name
File util/coreboot-configurator/src/application/qtyaml.h:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132749): https://review.coreboot.org/c/coreboot/+/58854/comment/cdf58443_fbea1481 PS37, Line 20: static Node encode(const QString & rhs) open brace '{' following function definitions go on the next line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132749): https://review.coreboot.org/c/coreboot/+/58854/comment/0962fd52_f0c16dfe PS37, Line 25: static bool decode(const Node & node, QString & rhs) open brace '{' following function definitions go on the next line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132749): https://review.coreboot.org/c/coreboot/+/58854/comment/33fa61a5_5d0e769b PS37, Line 38: static Node encode(const QMap < Key,Value > &rhs) space required after that ',' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132749): https://review.coreboot.org/c/coreboot/+/58854/comment/12203ef6_37a526f9 PS37, Line 38: static Node encode(const QMap < Key,Value > &rhs) open brace '{' following function definitions go on the next line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132749): https://review.coreboot.org/c/coreboot/+/58854/comment/70a41fb8_2944415a PS37, Line 49: static bool decode(const Node & node, QMap < Key, Value > &rhs) open brace '{' following function definitions go on the next line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132749): https://review.coreboot.org/c/coreboot/+/58854/comment/f2424240_3d3311b0 PS37, Line 68: static Node encode(const QVector < T > & rhs) space prohibited after that '&' (ctx:WxW)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132749): https://review.coreboot.org/c/coreboot/+/58854/comment/871b6ce4_98b586e5 PS37, Line 68: static Node encode(const QVector < T > & rhs) open brace '{' following function definitions go on the next line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132749): https://review.coreboot.org/c/coreboot/+/58854/comment/497b3e81_65eb652c PS37, Line 77: static bool decode(const Node & node, QVector < T > &rhs) open brace '{' following function definitions go on the next line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132749): https://review.coreboot.org/c/coreboot/+/58854/comment/c43f4b78_ddb2759d PS37, Line 96: static Node encode(const QList < T > &rhs) open brace '{' following function definitions go on the next line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132749): https://review.coreboot.org/c/coreboot/+/58854/comment/22c09272_f79fcc84 PS37, Line 99: foreach (T value, rhs) { space prohibited between function name and open parenthesis '('
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132749): https://review.coreboot.org/c/coreboot/+/58854/comment/1c539ca6_5457e812 PS37, Line 105: static bool decode(const Node & node, QList < T > &rhs) open brace '{' following function definitions go on the next line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132749): https://review.coreboot.org/c/coreboot/+/58854/comment/c3b0be19_e78f62ca PS37, Line 124: static Node encode(const QPair < T, U > &rhs) open brace '{' following function definitions go on the next line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132749): https://review.coreboot.org/c/coreboot/+/58854/comment/7bbb12eb_e3ca976e PS37, Line 133: static bool decode(const Node & node, QPair < T, U > &rhs) open brace '{' following function definitions go on the next line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132749): https://review.coreboot.org/c/coreboot/+/58854/comment/d4795044_0d6aee1f PS37, Line 150: static Node encode(const QStringList & rhs) open brace '{' following function definitions go on the next line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132749): https://review.coreboot.org/c/coreboot/+/58854/comment/011220e0_e815c950 PS37, Line 153: for (const auto &value: rhs) { need consistent spacing around '&' (ctx:WxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132749): https://review.coreboot.org/c/coreboot/+/58854/comment/749fc95f_48dbb191 PS37, Line 153: for (const auto &value: rhs) { spaces required around that ':' (ctx:VxW)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132749): https://review.coreboot.org/c/coreboot/+/58854/comment/ef3930b2_c08e301e PS37, Line 153: for (const auto &value: rhs) { braces {} are not necessary for single statement blocks
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132749): https://review.coreboot.org/c/coreboot/+/58854/comment/f0c9f701_8bb534c0 PS37, Line 159: static bool decode(const Node & node, QStringList & rhs) open brace '{' following function definitions go on the next line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132749): https://review.coreboot.org/c/coreboot/+/58854/comment/fd17d55e_3db1a2eb PS37, Line 166: while (it != node.end()) that open brace { should be on the previous line
-
build bot (Jenkins) (Code Review)