Stefan Reinauer has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/46666 )
Change subject: ectool: Add newline to warning message ......................................................................
ectool: Add newline to warning message
Cosmetic fix:
$ sudo ./ectool -p Cannot get EC ports from /proc/ioports, fallback to default.EC RAM:
Change-Id: Icc2b5bbbbfe7685e4fe512af029ce00b33a26daa Signed-off-by: Stefan Reinauer stefan.reinauer@coreboot.org --- M util/ectool/ectool.c 1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/66/46666/1
diff --git a/util/ectool/ectool.c b/util/ectool/ectool.c index 0b238c4..cb6f280 100644 --- a/util/ectool/ectool.c +++ b/util/ectool/ectool.c @@ -127,7 +127,7 @@
if (get_ports && get_ec_ports() != 0) fprintf(stderr, "Cannot get EC ports from /proc/ioports, " - "fallback to default."); + "fallback to default.\n");
if (iopl(3)) { printf("You need to be root.\n");
Felix Singer has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46666 )
Change subject: ectool: Add newline to warning message ......................................................................
Patch Set 1: Code-Review+2
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46666 )
Change subject: ectool: Add newline to warning message ......................................................................
Patch Set 1: Code-Review+2
Patrick Georgi has submitted this change. ( https://review.coreboot.org/c/coreboot/+/46666 )
Change subject: ectool: Add newline to warning message ......................................................................
ectool: Add newline to warning message
Cosmetic fix:
$ sudo ./ectool -p Cannot get EC ports from /proc/ioports, fallback to default.EC RAM:
Change-Id: Icc2b5bbbbfe7685e4fe512af029ce00b33a26daa Signed-off-by: Stefan Reinauer stefan.reinauer@coreboot.org Reviewed-on: https://review.coreboot.org/c/coreboot/+/46666 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Felix Singer felixsinger@posteo.net Reviewed-by: Angel Pons th3fanbus@gmail.com --- M util/ectool/ectool.c 1 file changed, 1 insertion(+), 1 deletion(-)
Approvals: build bot (Jenkins): Verified Felix Singer: Looks good to me, approved Angel Pons: Looks good to me, approved
diff --git a/util/ectool/ectool.c b/util/ectool/ectool.c index 0b238c4..cb6f280 100644 --- a/util/ectool/ectool.c +++ b/util/ectool/ectool.c @@ -127,7 +127,7 @@
if (get_ports && get_ec_ports() != 0) fprintf(stderr, "Cannot get EC ports from /proc/ioports, " - "fallback to default."); + "fallback to default.\n");
if (iopl(3)) { printf("You need to be root.\n");