Change in coreboot[master]: mb/kontron/bsl6: Move GPIO configuration to C file - coreboot-gerrit

24 Nov 2020


      Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47851 )
Change subject: mb/kontron/bsl6: Move GPIO configuration to C file
......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/c/coreboot/+/47851/2/src/mainboard/kontron/bsl6/... 
File src/mainboard/kontron/bsl6/ramstage.c:
https://review.coreboot.org/c/coreboot/+/47851/2/src/mainboard/kontron/bsl6/... 
PS2, Line 6: void mainboard_silicon_init_params(FSP_SIL_UPD *params)
Btw. this can also be done in the mainboard's chip_operation's .init, I
guess. Not sure why I didn't take care of it during review.
-- 
To view, visit https://review.coreboot.org/c/coreboot/+/47851
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I008de1bf91ba97ee5eefbde11947c73059fff5f7
Gerrit-Change-Number: 47851
Gerrit-PatchSet: 2
Gerrit-Owner:  Felix Singer felixsinger@posteo.net
Gerrit-Reviewer: Martin Roth martinroth@google.com
Gerrit-Reviewer: Nico Huber nico.h@gmx.de
Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-Comment-Date: Tue, 24 Nov 2020 19:46:07 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment