Change in coreboot[master]: soc/intel/common/acpi: work around Windows crash on S0ix-enabled boards
Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47138 )
Change subject: soc/intel/common/acpi: work around Windows crash on S0ix-enabled boards ......................................................................
Patch Set 8:
(4 comments)
https://review.coreboot.org/c/coreboot/+/47138/8/src/soc/intel/common/block/... File src/soc/intel/common/block/acpi/acpi/pep.asl:
https://review.coreboot.org/c/coreboot/+/47138/8/src/soc/intel/common/block/... PS8, Line 23: 1 You can skip the count here and below.
https://review.coreboot.org/c/coreboot/+/47138/8/src/soc/intel/common/block/... PS8, Line 23: DEVY Why create a named object when it is really used once (same logic as your previous CL for UUID)?
https://review.coreboot.org/c/coreboot/+/47138/8/src/soc/intel/common/block/... PS8, Line 31: DUMMY I don't think we can use "DUMMY" here. This has to be a fully-qualified namestring as per the spec.
https://review.coreboot.org/c/coreboot/+/47138/8/src/soc/intel/common/block/... PS8, Line 32: 0, I know you have captured this in the comment above already. But can you please add individual comments for the package elements too? It is just easier to read without having to go back to spec. e.g. /* Disabled, no constraints */ on this line.
-
Furquan Shaikh (Code Review)