Attention is currently required from: Furquan Shaikh, Meera Ravindranath, Andrey Petrov, Patrick Rudolph. build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/50241 )
Change subject: drivers/intel/fsp2_0/memory_init: check if UPD struct has expected size ......................................................................
Patch Set 2:
(10 comments)
File src/drivers/intel/fsp2_0/memory_init.c:
https://review.coreboot.org/c/coreboot/+/50241/comment/93a85176_06498264 PS2, Line 242: /* trailing whitespace
https://review.coreboot.org/c/coreboot/+/50241/comment/dc131924_1b8e05da PS2, Line 244: * use a static buffer for the FSP-M UPDs which is sizeof(FSPM_UPD) trailing whitespace
https://review.coreboot.org/c/coreboot/+/50241/comment/fa3cf0d2_61c9a60d PS2, Line 245: * byes long, since that is the value known at compile time. If trailing whitespace
https://review.coreboot.org/c/coreboot/+/50241/comment/366f8d64_0eac1687 PS2, Line 246: * hdr->cfg_region_size is bigger than that, not all UPD defaults will trailing whitespace
https://review.coreboot.org/c/coreboot/+/50241/comment/f69c8675_ff3f3156 PS2, Line 247: * be copied, so it'll contain random data at the end, so we just call trailing whitespace
https://review.coreboot.org/c/coreboot/+/50241/comment/7d8f1bf9_c2f23903 PS2, Line 248: * die() in that case. If hdr->cfg_region_size is smaller than that, trailing whitespace
https://review.coreboot.org/c/coreboot/+/50241/comment/c90927b6_675785a0 PS2, Line 249: * there's a mismatch between the FSP and the header, but since it trailing whitespace
https://review.coreboot.org/c/coreboot/+/50241/comment/525420f3_b7677027 PS2, Line 250: * will copy the full UPD defaults to the buffer, we try to continue trailing whitespace
https://review.coreboot.org/c/coreboot/+/50241/comment/abc55497_386b351a PS2, Line 251: * and hope that there wasn't any incompatible change in the UPDs. 'wasn' may be misspelled - perhaps 'was'?
https://review.coreboot.org/c/coreboot/+/50241/comment/c4de3840_55b8e7a4 PS2, Line 252: */ trailing whitespace