Nico Huber has submitted this change. ( https://review.coreboot.org/c/coreboot/+/56608 )
Change subject: ec/roda/it8518/acpi: Use lower-case hex format ......................................................................
ec/roda/it8518/acpi: Use lower-case hex format
Built roda/rw11 with `BUILD_TIMELESS=1` and coreboot.rom remains the same.
Change-Id: I9f08b048d41ab7a5d7d7dc735779ea019517491a Signed-off-by: Felix Singer felix.singer@secunet.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/56608 Reviewed-by: Nico Huber nico.h@gmx.de Reviewed-by: Angel Pons th3fanbus@gmail.com Tested-by: build bot (Jenkins) no-reply@coreboot.org --- M src/ec/roda/it8518/acpi/battery.asl M src/ec/roda/it8518/acpi/ec.asl 2 files changed, 12 insertions(+), 12 deletions(-)
Approvals: build bot (Jenkins): Verified Nico Huber: Looks good to me, approved Angel Pons: Looks good to me, but someone else must approve
diff --git a/src/ec/roda/it8518/acpi/battery.asl b/src/ec/roda/it8518/acpi/battery.asl index e9e7edb..7180ace 100644 --- a/src/ec/roda/it8518/acpi/battery.asl +++ b/src/ec/roda/it8518/acpi/battery.asl @@ -33,9 +33,9 @@ Name (PBST, Package (4) { 0x00000000, // Battery State - 0xFFFFFFFF, // Battery Present Rate - 0xFFFFFFFF, // Battery Remaining Capacity - 0xFFFFFFFF, // Battery Present Voltage + 0xffffffff, // Battery Present Rate + 0xffffffff, // Battery Remaining Capacity + 0xffffffff, // Battery Present Voltage })
@@ -44,13 +44,13 @@ { Printf ("-----> BAT0: _STA")
- Local0 = 0x0F + Local0 = 0x0f
Local1 = ECPS Local1 &= 0x02 If (Local1 == 0x02) { - Local0 = 0x1F + Local0 = 0x1f }
Printf ("<----- BAT0: _STA") diff --git a/src/ec/roda/it8518/acpi/ec.asl b/src/ec/roda/it8518/acpi/ec.asl index 8b89075..3b9a38d 100644 --- a/src/ec/roda/it8518/acpi/ec.asl +++ b/src/ec/roda/it8518/acpi/ec.asl @@ -11,7 +11,7 @@ Name (LIDS, 1)
// EC RAM fields - OperationRegion(ERAM, EmbeddedControl, 0, 0xFF) + OperationRegion(ERAM, EmbeddedControl, 0, 0xff) Field (ERAM, ByteAcc, NoLock, Preserve) { Offset(0x02), // [Configuration Space 0x2] @@ -31,13 +31,13 @@ Offset (0x50), // [Configuration Space 0x50] LUXH, 8, // Ambient Light Illuminance High LUXL, 8, // Ambient Light Illuminance Low - Offset (0x5B), // [Configuration Space 0x5B] + Offset (0x5b), // [Configuration Space 0x5b] BRIG, 8, // Brightness } // End of ERAM
Method (_STA, 0, NotSerialized) // _STA: Status { - Return (0x0F) + Return (0x0f) }
Method (_CRS, 0, NotSerialized) @@ -134,8 +134,8 @@
Local0 = BRIG Local0 += 1 - If (Local0 > 0xAA) { - Local0 = 0xAA + If (Local0 > 0xaa) { + Local0 = 0xaa } BRIG = Local0
@@ -150,9 +150,9 @@
Local0 = BRIG Local0 -= 1 - If (Local0 < 0xA0) + If (Local0 < 0xa0) { - Local0 = 0xA0 + Local0 = 0xa0 } BRIG = Local0