Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36246 )
Change subject: mainboard/intel/tigerlake_rvp:Add flash layout file ......................................................................
Patch Set 3:
(4 comments)
This fmap is unused.
Try to specify base and size the least amount possible. It makes it a lot less errorprone.
https://review.coreboot.org/c/coreboot/+/36246/3/src/mainboard/intel/tigerla... File src/mainboard/intel/tigerlake_rvp/chromeos.fmd:
https://review.coreboot.org/c/coreboot/+/36246/3/src/mainboard/intel/tigerla... PS3, Line 10: @0x10000 0x2bffc0 don't specify base and size.
https://review.coreboot.org/c/coreboot/+/36246/3/src/mainboard/intel/tigerla... PS3, Line 33: 0x7d0000 0x430000 Don't specify base and size.
https://review.coreboot.org/c/coreboot/+/36246/3/src/mainboard/intel/tigerla... PS3, Line 36: FMAP@0x0 0x800 : RO_FRID@0x800 0x40 : RO_FRID_PAD@0x840 0x7c0 : GBB@0x1000 0xef000 Only necessary to specify the sizes, not the base.
https://review.coreboot.org/c/coreboot/+/36246/3/src/mainboard/intel/tigerla... PS3, Line 40: @0xf0000 0x33c000 Don't specify base and size to make sure it is aligned to bottom.
-
Arthur Heymans (Code Review)