Attention is currently required from: Rob Barnes, Karthik Ramasubramanian, Felix Held. build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/61259 )
Change subject: soc/amd/cezanne: Turn off gpp clock request for disabled devices ......................................................................
Patch Set 19:
(5 comments)
File src/soc/amd/cezanne/fch.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-140458): https://review.coreboot.org/c/coreboot/+/61259/comment/20fbb07d_85f7ec53 PS19, Line 161: /* trailing whitespace
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-140458): https://review.coreboot.org/c/coreboot/+/61259/comment/2418a63f_6af4ce6c PS19, Line 167: printk(BIOS_WARNING, trailing whitespace
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-140458): https://review.coreboot.org/c/coreboot/+/61259/comment/4a46a1a5_f764430b PS19, Line 168: "CLK_ENABLE is an invalid clk_req value for PCIe device %d.%d, DXIO descriptior %d\n", 'descriptior' may be misspelled - perhaps 'descriptor'?
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-140458): https://review.coreboot.org/c/coreboot/+/61259/comment/b4422d53_b1f29752 PS19, Line 181: dxio_desc->device_number, dxio_desc->function_number, i); line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-140458): https://review.coreboot.org/c/coreboot/+/61259/comment/658f300f_80e1d139 PS19, Line 221: } else if (pci_device->enabled trailing whitespace