Patrick Georgi has submitted this change and it was merged. ( https://review.coreboot.org/c/coreboot/+/31990 )
Change subject: sb/{amd,broadcom,nvidia}: Make use of generic set_subsystem() ......................................................................
sb/{amd,broadcom,nvidia}: Make use of generic set_subsystem()
Change-Id: I99b87004ea74a1ad0ec1d6e0c500df11dae4997c Signed-off-by: Kyösti Mälkki kyosti.malkki@gmail.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/31990 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Patrick Georgi pgeorgi@google.com --- M src/southbridge/amd/amd8111/ac97.c M src/southbridge/broadcom/bcm5785/sb_pci_main.c 2 files changed, 2 insertions(+), 16 deletions(-)
Approvals: build bot (Jenkins): Verified Patrick Georgi: Looks good to me, approved
diff --git a/src/southbridge/amd/amd8111/ac97.c b/src/southbridge/amd/amd8111/ac97.c index c952cce..267c436 100644 --- a/src/southbridge/amd/amd8111/ac97.c +++ b/src/southbridge/amd/amd8111/ac97.c @@ -19,15 +19,8 @@ #include <device/pci_ops.h> #include "amd8111.h"
-static void lpci_set_subsystem(struct device *dev, unsigned int vendor, - unsigned int device) -{ - pci_write_config32(dev, 0x2c, - ((device & 0xffff) << 16) | (vendor & 0xffff)); -} - static struct pci_operations lops_pci = { - .set_subsystem = lpci_set_subsystem, + .set_subsystem = pci_dev_set_subsystem, };
static struct device_operations ac97audio_ops = { diff --git a/src/southbridge/broadcom/bcm5785/sb_pci_main.c b/src/southbridge/broadcom/bcm5785/sb_pci_main.c index 6ef335b..759cb5d 100644 --- a/src/southbridge/broadcom/bcm5785/sb_pci_main.c +++ b/src/southbridge/broadcom/bcm5785/sb_pci_main.c @@ -134,15 +134,8 @@ .write_byte = lsmbus_write_byte, };
-static void lpci_set_subsystem(struct device *dev, unsigned vendor, - unsigned device) -{ - pci_write_config32(dev, 0x2c, - ((device & 0xffff) << 16) | (vendor & 0xffff)); -} - static struct pci_operations lops_pci = { - .set_subsystem = lpci_set_subsystem, + .set_subsystem = pci_dev_set_subsystem, };
static struct device_operations sb_ops = {