Attention is currently required from: Matt DeVillier, Paul Menzel, Leah Rowe.
Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/51168 )
Change subject: util/chromeos: Verify sha1sums of downloaded recovery images
......................................................................
Patch Set 1:
(3 comments)
File util/chromeos/crosfirmware.sh:
https://review.coreboot.org/c/coreboot/+/51168/comment/6a16f2f0_cdcf0b28
PS1, Line 51: sha1_list="$(grep sha1 ${_cfgfile} | sed 's/sha1=//g')"
Why check against all sha1sums and not just the one for the board you need?
https://review.coreboot.org/c/coreboot/+/51168/comment/658b27a3_4fd8e32c
PS1, Line 138:
Please remove.
https://review.coreboot.org/c/coreboot/+/51168/comment/3c408911_ee6fbd54
PS1, Line 168:
Please remove.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/51168
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I2b21c89f2d2d89f4a161a0aa5eea904ca547cb80
Gerrit-Change-Number: 51168
Gerrit-PatchSet: 1
Gerrit-Owner: Leah Rowe
leahleahrowerowe@gmail.com
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Matt DeVillier
matt.devillier@gmail.com
Gerrit-Reviewer: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Matt DeVillier
matt.devillier@gmail.com
Gerrit-Attention: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Attention: Leah Rowe
leahleahrowerowe@gmail.com
Gerrit-Comment-Date: Tue, 02 Mar 2021 07:21:43 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment