Felix Held has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/74299 )
Change subject: mb/amd/birman/port_descriptors_*: use DDI_DP_W_TYPEC type for DDI 2..4 ......................................................................
mb/amd/birman/port_descriptors_*: use DDI_DP_W_TYPEC type for DDI 2..4
DDI 2..4 are the display outputs multiplexed onto the 3 USB type C ports as DisplayPort alternate function, so use the DDI_DP_W_TYPEC connector type for those.
Signed-off-by: Felix Held felix-coreboot@felixheld.de Change-Id: I659d62bfb426e3e47214203490c34e9c200beee2 --- M src/mainboard/amd/birman/port_descriptors_glinda.c M src/mainboard/amd/birman/port_descriptors_phoenix.c 2 files changed, 22 insertions(+), 8 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/99/74299/1
diff --git a/src/mainboard/amd/birman/port_descriptors_glinda.c b/src/mainboard/amd/birman/port_descriptors_glinda.c index a2c4557..df961bf 100644 --- a/src/mainboard/amd/birman/port_descriptors_glinda.c +++ b/src/mainboard/amd/birman/port_descriptors_glinda.c @@ -63,17 +63,17 @@ .hdp_index = DDI_HDP2 }, { /* DDI2 - DP (type C) */ - .connector_type = DDI_DP, + .connector_type = DDI_DP_W_TYPEC, .aux_index = DDI_AUX3, .hdp_index = DDI_HDP3, }, { /* DDI3 - DP (type C) */ - .connector_type = DDI_DP, + .connector_type = DDI_DP_W_TYPEC, .aux_index = DDI_AUX4, .hdp_index = DDI_HDP4, }, - { /* DDI4 - unused */ - .connector_type = DDI_UNUSED_TYPE, + { /* DDI4 - DP (type C) */ + .connector_type = DDI_DP_W_TYPEC, .aux_index = DDI_AUX5, .hdp_index = DDI_HDP5, } diff --git a/src/mainboard/amd/birman/port_descriptors_phoenix.c b/src/mainboard/amd/birman/port_descriptors_phoenix.c index a2c4557..df961bf 100644 --- a/src/mainboard/amd/birman/port_descriptors_phoenix.c +++ b/src/mainboard/amd/birman/port_descriptors_phoenix.c @@ -63,17 +63,17 @@ .hdp_index = DDI_HDP2 }, { /* DDI2 - DP (type C) */ - .connector_type = DDI_DP, + .connector_type = DDI_DP_W_TYPEC, .aux_index = DDI_AUX3, .hdp_index = DDI_HDP3, }, { /* DDI3 - DP (type C) */ - .connector_type = DDI_DP, + .connector_type = DDI_DP_W_TYPEC, .aux_index = DDI_AUX4, .hdp_index = DDI_HDP4, }, - { /* DDI4 - unused */ - .connector_type = DDI_UNUSED_TYPE, + { /* DDI4 - DP (type C) */ + .connector_type = DDI_DP_W_TYPEC, .aux_index = DDI_AUX5, .hdp_index = DDI_HDP5, }