Attention is currently required from: Felix Singer, Lance Zhao, Jason Glenesk, Raul Rangel, Nico Huber, Furquan Shaikh, Marshall Dawson, Tim Wawrzynczak, Angel Pons, Patrick Rudolph, Felix Held. build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/58118 )
Change subject: acpigen,soc/amd/cezanne,intel/{common,skl}: rework CPPC table passing ......................................................................
Patch Set 5:
(14 comments)
File src/soc/amd/cezanne/cppc.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-130063): https://review.coreboot.org/c/coreboot/+/58118/comment/f8ff249f_88db1f26 PS5, Line 15: [CPPC_HIGHEST_PERF] = CPPC_REG_MSR(MSR_CPPC_CAPABILITY_1, SHIFT_CPPC_CAPABILITY_1_HIGHEST_PERF, 8), line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-130063): https://review.coreboot.org/c/coreboot/+/58118/comment/c502b941_9493a558 PS5, Line 16: [CPPC_NOMINAL_PERF] = CPPC_REG_MSR(MSR_CPPC_CAPABILITY_1, SHIFT_CPPC_CAPABILITY_1_NOMINAL_PERF, 8), line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-130063): https://review.coreboot.org/c/coreboot/+/58118/comment/ecb52729_d92ac7d5 PS5, Line 17: [CPPC_LOWEST_NONL_PERF] = CPPC_REG_MSR(MSR_CPPC_CAPABILITY_1, SHIFT_CPPC_CAPABILITY_1_LOW_NON_LIN_PERF, 8), line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-130063): https://review.coreboot.org/c/coreboot/+/58118/comment/09d527ed_80114ee8 PS5, Line 18: [CPPC_LOWEST_PERF] = CPPC_REG_MSR(MSR_CPPC_CAPABILITY_1, SHIFT_CPPC_CAPABILITY_1_LOWEST_PERF, 8), line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-130063): https://review.coreboot.org/c/coreboot/+/58118/comment/1ebbca4e_1e63ff51 PS5, Line 20: [CPPC_DESIRED_PERF] = CPPC_REG_MSR(MSR_CPPC_REQUEST, SHIFT_CPPC_REQUEST_DES_PERF, 8), line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-130063): https://review.coreboot.org/c/coreboot/+/58118/comment/20aec8af_cefeb3ab PS5, Line 21: [CPPC_MIN_PERF] = CPPC_REG_MSR(MSR_CPPC_REQUEST, SHIFT_CPPC_REQUEST_MIN_PERF, 8), line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-130063): https://review.coreboot.org/c/coreboot/+/58118/comment/6cde550e_9948c649 PS5, Line 22: [CPPC_MAX_PERF] = CPPC_REG_MSR(MSR_CPPC_REQUEST, SHIFT_CPPC_REQUEST_MAX_PERF, 8), line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-130063): https://review.coreboot.org/c/coreboot/+/58118/comment/0455c36d_c06eabd2 PS5, Line 26: [CPPC_REF_PERF_COUNTER] = CPPC_REG( ACPI_REG_MSR(MSR_MAX_PERFORMANCE_FREQUENCY_CLOCK_COUNT, 0, 64), line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-130063): https://review.coreboot.org/c/coreboot/+/58118/comment/81860434_047e5900 PS5, Line 26: [CPPC_REF_PERF_COUNTER] = CPPC_REG( ACPI_REG_MSR(MSR_MAX_PERFORMANCE_FREQUENCY_CLOCK_COUNT, 0, 64), space prohibited after that open parenthesis '('
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-130063): https://review.coreboot.org/c/coreboot/+/58118/comment/a478ddd8_ee521a60 PS5, Line 27: [CPPC_DELIVERED_PERF_COUNTER] = CPPC_REG( ACPI_REG_MSR(MSR_ACTUAL_PERFORMANCE_FREQUENCY_CLOCK_COUNT, 0, 64), line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-130063): https://review.coreboot.org/c/coreboot/+/58118/comment/859644e0_19095b47 PS5, Line 27: [CPPC_DELIVERED_PERF_COUNTER] = CPPC_REG( ACPI_REG_MSR(MSR_ACTUAL_PERFORMANCE_FREQUENCY_CLOCK_COUNT, 0, 64), space prohibited after that open parenthesis '('
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-130063): https://review.coreboot.org/c/coreboot/+/58118/comment/c04daedf_382e5fb4 PS5, Line 28: [CPPC_PERF_LIMITED] = CPPC_REG( ACPI_REG_MSR(MSR_CPPC_STATUS, 1, 1), space prohibited after that open parenthesis '('
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-130063): https://review.coreboot.org/c/coreboot/+/58118/comment/33a677c3_d4591a29 PS5, Line 29: [CPPC_ENABLE] = CPPC_REG( ACPI_REG_MSR(MSR_CPPC_ENABLE, 0, 1), space prohibited after that open parenthesis '('
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-130063): https://review.coreboot.org/c/coreboot/+/58118/comment/9042a181_d6fe1b3b PS5, Line 34: [CPPC_PERF_PREF] = CPPC_REG_MSR(MSR_CPPC_REQUEST, SHIFT_CPPC_REQUEST_ENERGY_PERF_PREF, 8), line over 96 characters