Attention is currently required from: Hung-Te Lin, Jarried Lin.
Andy Hsu has posted comments on this change by Jarried Lin. ( https://review.coreboot.org/c/coreboot/+/85654?usp=email )
Change subject: soc/mediatek/mt8196: Add GPUEB support
......................................................................
Patch Set 3:
(1 comment)
File src/soc/mediatek/mt8196/gpueb.c:
https://review.coreboot.org/c/coreboot/+/85654/comment/e60e71a9_e5e6ef58?usp... :
PS2, Line 358: die
Is the gpueb init flow critical for the device to boot up? If not, I wonder if we can print an error […]
The gpueb init flow is critical for boot up. If issues are not detected at this stage, it will be difficult to identify the problem later in the kernel driver, such as whether it is a firmware load failure or a register setting issue.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/85654?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I0f10dfc753f73df97ea08a4c23e97de416832be2
Gerrit-Change-Number: 85654
Gerrit-PatchSet: 3
Gerrit-Owner: Jarried Lin
jarried.lin@mediatek.com
Gerrit-Reviewer: Andy Hsu
andy.hsu@mediatek.corp-partner.google.com
Gerrit-Reviewer: Hung-Te Lin
hungte@chromium.org
Gerrit-Reviewer: Yidi Lin
yidilin@google.com
Gerrit-Reviewer: Yu-Ping Wu
yupingso@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Hung-Te Lin
hungte@chromium.org
Gerrit-Attention: Jarried Lin
jarried.lin@mediatek.com
Gerrit-Comment-Date: Mon, 23 Dec 2024 12:54:07 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Yu-Ping Wu
yupingso@google.com