Chen Wisley has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/34583 )
Change subject: mb/google/octopus: Add keyboard backlight support ......................................................................
mb/google/octopus: Add keyboard backlight support
Dorp device support keyboard backlight, so enable it.
BUG=b:138413969 BRANCH=octopus TEST=emerge-octopus coreboot
Change-Id: If0c7b22b4be2a5d5216404a6944ac887883e9a47 Signed-off-by: Wisley Chen wisley.chen@quantatw.com --- M src/mainboard/google/octopus/variants/meep/include/variant/ec.h 1 file changed, 3 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/83/34583/1
diff --git a/src/mainboard/google/octopus/variants/meep/include/variant/ec.h b/src/mainboard/google/octopus/variants/meep/include/variant/ec.h index 16f931b..196d52e 100644 --- a/src/mainboard/google/octopus/variants/meep/include/variant/ec.h +++ b/src/mainboard/google/octopus/variants/meep/include/variant/ec.h @@ -18,4 +18,7 @@
#include <baseboard/ec.h>
+/* Enable EC backed Keyboard Backlight in ACPI */ +#define EC_ENABLE_KEYBOARD_BACKLIGHT + #endif
Justin TerAvest has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34583 )
Change subject: mb/google/octopus: Add keyboard backlight support ......................................................................
Patch Set 1: Code-Review+2
Marco Chen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34583 )
Change subject: mb/google/octopus: Add keyboard backlight support ......................................................................
Patch Set 1: Code-Review+1
Furquan Shaikh has submitted this change and it was merged. ( https://review.coreboot.org/c/coreboot/+/34583 )
Change subject: mb/google/octopus: Add keyboard backlight support ......................................................................
mb/google/octopus: Add keyboard backlight support
Dorp device support keyboard backlight, so enable it.
BUG=b:138413969 BRANCH=octopus TEST=emerge-octopus coreboot
Change-Id: If0c7b22b4be2a5d5216404a6944ac887883e9a47 Signed-off-by: Wisley Chen wisley.chen@quantatw.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/34583 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Justin TerAvest teravest@chromium.org Reviewed-by: Marco Chen marcochen@google.com --- M src/mainboard/google/octopus/variants/meep/include/variant/ec.h 1 file changed, 3 insertions(+), 0 deletions(-)
Approvals: build bot (Jenkins): Verified Justin TerAvest: Looks good to me, approved Marco Chen: Looks good to me, but someone else must approve
diff --git a/src/mainboard/google/octopus/variants/meep/include/variant/ec.h b/src/mainboard/google/octopus/variants/meep/include/variant/ec.h index 16f931b..196d52e 100644 --- a/src/mainboard/google/octopus/variants/meep/include/variant/ec.h +++ b/src/mainboard/google/octopus/variants/meep/include/variant/ec.h @@ -18,4 +18,7 @@
#include <baseboard/ec.h>
+/* Enable EC backed Keyboard Backlight in ACPI */ +#define EC_ENABLE_KEYBOARD_BACKLIGHT + #endif
-
Chen Wisley (Code Review) -
Furquan Shaikh (Code Review)
-
Justin TerAvest (Code Review)
-
Marco Chen (Code Review)