Attention is currently required from: Julius Werner, Paul Menzel.
Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/69747?usp=email )
Change subject: arch/arm: Build test all arm targets with clang
......................................................................
Patch Set 20:
(1 comment)
File src/soc/nvidia/tegra124/Kconfig:
https://review.coreboot.org/c/coreboot/+/69747/comment/ac538fec_4d1131a6 :
PS20, Line 20: default n if SOC_NVIDIA_TEGRA124 && CHROMEOS
Why not move these into the `if SOC_...` blocks below?
That does not work. Kconfig then thinks SOC_NVIDIA_TEGRA124 is a dependency.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/69747?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I88cf8ce16fb6c61c19d615e396f5871179b06fc8
Gerrit-Change-Number: 69747
Gerrit-PatchSet: 20
Gerrit-Owner: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Martin L Roth
gaumless@gmail.com
Gerrit-Reviewer: Paul Menzel
paulepanter@mailbox.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Stefan Reinauer
stefan.reinauer@coreboot.org
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Julius Werner
jwerner@chromium.org
Gerrit-Comment-Date: Fri, 23 Feb 2024 08:39:01 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Julius Werner
jwerner@chromium.org
Gerrit-MessageType: comment