Change in coreboot[master]: [TESTME]msi/ms7721: fix the VGA-related PCI resource allocation problems

List overview All Threads
Download

newer

older

Change in coreboot[master]:...

Mike Banon (Code Review)

6 Jan 2020 6 Jan '20

12:20 p.m.

Mike Banon has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/38216 )

Change subject: [TESTME]msi/ms7721: fix the VGA-related PCI resource allocation problems ......................................................................

[TESTME]msi/ms7721: fix the VGA-related PCI resource allocation problems

This workaround helps to avoid the PCI resource allocation problems which happen if a discrete VGA adapter (i.e. AMD HD6670) has been plugged in to MS7721 board. It does not bring any downsides if there is no discrete VGA adapter.

Signed-off-by: Mike Banon mikebdp2@gmail.com Change-Id: I97f224772710d561808c7cf0f412caea4bd6b560 --- M src/mainboard/msi/ms7721/OemCustomize.c 1 file changed, 2 insertions(+), 0 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/16/38216/1

diff --git a/src/mainboard/msi/ms7721/OemCustomize.c b/src/mainboard/msi/ms7721/OemCustomize.c index 4782e11..8baa686 100644 --- a/src/mainboard/msi/ms7721/OemCustomize.c +++ b/src/mainboard/msi/ms7721/OemCustomize.c @@ -187,6 +187,8 @@

void board_BeforeInitPost(struct sysinfo *cb, AMD_POST_PARAMS *InitPost) { + /* Set to 0xD0 instead of 0xE0 to avoid the PCI resource allocation problems. */ + InitPost->MemConfig.BottomIo = 0xD0; InitPost->MemConfig.PlatformMemoryConfiguration = (PSO_ENTRY *)PlatformMemoryTable; }

Attachments:

attachment.htm (text/html — 2.7 KB)

Show replies by date

Mike Banon (Code Review)

6 Jan 6 Jan

12:51 p.m.

Mike Banon has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38216 )

Change subject: [TESTME]msi/ms7721: fix the VGA-related PCI resource allocation problems ......................................................................

Patch Set 1:

Please review, hopefully you have a spare discrete GPU to test this.

-- To view, visit https://review.coreboot.org/c/coreboot/+/38216 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I97f224772710d561808c7cf0f412caea4bd6b560 Gerrit-Change-Number: 38216 Gerrit-PatchSet: 1 Gerrit-Owner: Mike Banon mikebdp2@gmail.com Gerrit-Reviewer: Mike Banon mikebdp2@gmail.com Gerrit-Reviewer: Renze Nicolai renze@rnplus.nl Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Comment-Date: Mon, 06 Jan 2020 12:51:24 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

Renze Nicolai (Code Review)

11 Jan 11 Jan

3:45 a.m.

Renze Nicolai has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38216 )

Change subject: [TESTME]msi/ms7721: fix the VGA-related PCI resource allocation problems ......................................................................

Patch Set 1:

First of all: thank you for putting in such effort to fix issues with this motherboard!

I'd love to review your work but I'm quite busy at the moment. I expect to be able to test this change somewhere around February or March 2020.

(On a sidenote and slightly off-topic: if you're willing to look into stuff for these boards, there are a couple of other issues that might need fixing... the ms7721 board does not properly wake up from sleep mode, doesn't always come back after a reboot and doesn't save settings to nvram properly as well, if you have any idea of why this may be please do let me know!)

Fun thing about the specific issue named in this pr is that I tested the 16x PCIe port using a graphics card when I initially added support for this board to coreboot and it did work back then. What kind of things can I expect to see when testing this patch? Do these "resource allocation problems" cause the external graphics card not to display/initialise properly?

-- To view, visit https://review.coreboot.org/c/coreboot/+/38216 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I97f224772710d561808c7cf0f412caea4bd6b560 Gerrit-Change-Number: 38216 Gerrit-PatchSet: 1 Gerrit-Owner: Mike Banon mikebdp2@gmail.com Gerrit-Reviewer: Mike Banon mikebdp2@gmail.com Gerrit-Reviewer: Renze Nicolai renze@rnplus.nl Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Sat, 11 Jan 2020 03:45:29 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

Mike Banon (Code Review)

8:32 a.m.

Mike Banon has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38216 )

Change subject: [TESTME]msi/ms7721: fix the VGA-related PCI resource allocation problems ......................................................................

Patch Set 1:

...

Patch Set 1:

First of all: thank you for putting in such effort to fix issues with this motherboard!

I'd love to review your work but I'm quite busy at the moment. I expect to be able to test this change somewhere around February or March 2020.

(On a sidenote and slightly off-topic: if you're willing to look into stuff for these boards, there are a couple of other issues that might need fixing... the ms7721 board does not properly wake up from sleep mode, doesn't always come back after a reboot and doesn't save settings to nvram properly as well, if you have any idea of why this may be please do let me know!)

Fun thing about the specific issue named in this pr is that I tested the 16x PCIe port using a graphics card when I initially added support for this board to coreboot and it did work back then. What kind of things can I expect to see when testing this patch? Do these "resource allocation problems" cause the external graphics card not to display/initialise properly?

Thank you very much too, for your reply! ;) As I don't have this motherboard, I could provide a fix only for the issues I've encountered on the other boards, and hope it would work for you as well - asking to [TESTME]. A few months ago indeed there was a problem with a "sleep mode" aka S3 Suspend, and after entering this broken mode it was impossible to power on until you'd completely discharge a board (i.e. by attempting to power on a board when its' power supply isn't connected to electricity, to discharge it completely). But this has been fixed recently, so a "sleep mode" should work for you fine.

Please tell, with what graphics card you have tested? I reproduce this issue with AMD HD6670 GPU on some different desktop AGESA boards. Also, I haven't observed any downsides from this fix yet. Check out this comment by Michal for more info about this fix - https://review.coreboot.org/c/coreboot/+/38224/2#message-efd01244126362afe68...

-- To view, visit https://review.coreboot.org/c/coreboot/+/38216 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I97f224772710d561808c7cf0f412caea4bd6b560 Gerrit-Change-Number: 38216 Gerrit-PatchSet: 1 Gerrit-Owner: Mike Banon mikebdp2@gmail.com Gerrit-Reviewer: Mike Banon mikebdp2@gmail.com Gerrit-Reviewer: Renze Nicolai renze@rnplus.nl Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Sat, 11 Jan 2020 08:32:41 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

Mike Banon (Code Review)

18 Jan 18 Jan

7:41 p.m.

Hello Renze Nicolai, build bot (Jenkins),

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/38216

to look at the new patch set (#2).

Change subject: [TESTME]msi/ms7721: fix the VGA-related PCI resource allocation problems ......................................................................

[TESTME]msi/ms7721: fix the VGA-related PCI resource allocation problems

Signed-off-by: Mike Banon mikebdp2@gmail.com Change-Id: I97f224772710d561808c7cf0f412caea4bd6b560 --- M src/mainboard/msi/ms7721/OemCustomize.c 1 file changed, 2 insertions(+), 0 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/16/38216/2

-- To view, visit https://review.coreboot.org/c/coreboot/+/38216 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I97f224772710d561808c7cf0f412caea4bd6b560 Gerrit-Change-Number: 38216 Gerrit-PatchSet: 2 Gerrit-Owner: Mike Banon mikebdp2@gmail.com Gerrit-Reviewer: Mike Banon mikebdp2@gmail.com Gerrit-Reviewer: Renze Nicolai renze@rnplus.nl Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-MessageType: newpatchset

Mike Banon (Code Review)

7:59 p.m.

Mike Banon has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38216 )

Change subject: [TESTME]msi/ms7721: fix the VGA-related PCI resource allocation problems ......................................................................

Patch Set 2:

(1 comment)

https://review.coreboot.org/c/coreboot/+/38216/2/src/mainboard/msi/ms7721/Oe... File src/mainboard/msi/ms7721/OemCustomize.c:

https://review.coreboot.org/c/coreboot/+/38216/2/src/mainboard/msi/ms7721/Oe... PS2, Line 190: /* Set to 0x40 instead of 0xE0 to avoid the PCI resource allocation problems. */ : InitPost->MemConfig.BottomIo = 0x40; See CB:30987 comment here for more info about this change from 0xD0 to 0x40 - https://review.coreboot.org/c/coreboot/+/30987/45/src/mainboard/asus/a88xm-e...

-- To view, visit https://review.coreboot.org/c/coreboot/+/38216 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I97f224772710d561808c7cf0f412caea4bd6b560 Gerrit-Change-Number: 38216 Gerrit-PatchSet: 2 Gerrit-Owner: Mike Banon mikebdp2@gmail.com Gerrit-Reviewer: Mike Banon mikebdp2@gmail.com Gerrit-Reviewer: Renze Nicolai renze@rnplus.nl Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Sat, 18 Jan 2020 19:59:50 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

Mike Banon (Code Review)

24 Jan 24 Jan

2:46 p.m.

Mike Banon has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/38216 )

Change subject: [TESTME]msi/ms7721: fix the VGA-related PCI resource allocation problems ......................................................................

Abandoned

Superseded by CB:38472 (amd/agesa: Make BottomIo position configurable)

-- To view, visit https://review.coreboot.org/c/coreboot/+/38216 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I97f224772710d561808c7cf0f412caea4bd6b560 Gerrit-Change-Number: 38216 Gerrit-PatchSet: 2 Gerrit-Owner: Mike Banon mikebdp2@gmail.com Gerrit-Reviewer: Mike Banon mikebdp2@gmail.com Gerrit-Reviewer: Renze Nicolai renze@rnplus.nl Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-MessageType: abandon

1770

days inactive

1788

days old

coreboot-gerrit@coreboot.org

6 comments

2 participants

tags (0)

participants (2)

Mike Banon (Code Review)
Renze Nicolai (Code Review)