Attention is currently required from: Subrata Banik, Tim Wawrzynczak, Angel Pons. Tarun Tuli has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/63969 )
Change subject: soc/intel/alderlake: provide a list of D-states to enter LPM ......................................................................
Patch Set 19:
(6 comments)
File src/soc/intel/alderlake/acpi.c:
https://review.coreboot.org/c/coreboot/+/63969/comment/8466beb9_483ff385 PS18, Line 183: // Index based on PCI_DEVFN() values
coreboot doesn't really use `//` style comments: […]
Done
https://review.coreboot.org/c/coreboot/+/63969/comment/ff17f87e_318950a1 PS18, Line 187:
nit: extra space
Done
https://review.coreboot.org/c/coreboot/+/63969/comment/ad1daae4_7cbbfc55 PS18, Line 247: if (!dev || !dev->enabled)
nit: […]
Done
https://review.coreboot.org/c/coreboot/+/63969/comment/e9b9848c_626c2726 PS18, Line 255: int
nit: […]
Done
https://review.coreboot.org/c/coreboot/+/63969/comment/08d8a2c3_983c04a0 PS18, Line 269: uint8_t
any particular reason this is 8 bits? why not `unsigned int` ?
Done
File src/soc/intel/common/block/acpi/pep.c:
https://review.coreboot.org/c/coreboot/+/63969/comment/e96db403_b4fe3b5e PS18, Line 77: lpi_get_constraints
suggestion: […]
Done