Change in coreboot[master]: {drivers,mainboard}: Move FSP logo support to fsp1_1 - coreboot-gerrit

13 Nov 2019


      Wim Vervoorn has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36679 )
Change subject: {drivers,mainboard}: Move FSP logo support to fsp1_1
......................................................................
Patch Set 13:
(1 comment)
https://review.coreboot.org/c/coreboot/+/36679/10/src/drivers/intel/fsp1_1/r... 
File src/drivers/intel/fsp1_1/ramstage.c:
https://review.coreboot.org/c/coreboot/+/36679/10/src/drivers/intel/fsp1_1/r... 
PS10, Line 124: if (CONFIG(FSP1_1_DISPLAY_LOGO) && !is_s3_wakeup)
              : 		cbmem_entry_remove(logo_entry);
...
It's pretty obvious to me, but it might be worth commenting here that the image is now in a framebuf […]
Done
-- 
To view, visit https://review.coreboot.org/c/coreboot/+/36679
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I276e6e14fc87d0b95fe5fdf7b617afd26769de79
Gerrit-Change-Number: 36679
Gerrit-PatchSet: 13
Gerrit-Owner: Wim Vervoorn wvervoorn@eltan.com
Gerrit-Reviewer: Aaron Durbin adurbin@chromium.org
Gerrit-Reviewer: Arthur Heymans arthur@aheymans.xyz
Gerrit-Reviewer: Frans Hendriks fhendriks@eltan.com
Gerrit-Reviewer: Huang Jin huang.jin@intel.com
Gerrit-Reviewer: Lee Leahy leroy.p.leahy@intel.com
Gerrit-Reviewer: Martin Roth martinroth@google.com
Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph siro@das-labor.org
Gerrit-Reviewer: Paul Menzel paulepanter@users.sourceforge.net
Gerrit-Reviewer: Wim Vervoorn wvervoorn@eltan.com
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-Comment-Date: Wed, 13 Nov 2019 09:51:37 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Arthur Heymans arthur@aheymans.xyz
Gerrit-MessageType: comment