Attention is currently required from: Alexander Couzens, Nicholas Chin, Paul Menzel.
Nicholas Sudsgaard has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/80343?usp=email )
Change subject: mainboard/lenovo: Add ThinkCentre M710s (Skylake) ......................................................................
Patch Set 4:
(3 comments)
Patchset:
PS3:
This needs to be rebased on top of your other patch in CB:80344 (superio/ifd: Add IT8629E) so that C […]
I didn't know you could do that (I'm not the best at git). Thanks for the explanation. 😊
File src/mainboard/lenovo/thinkcentre_m710s/acpi/ec.asl:
https://review.coreboot.org/c/coreboot/+/80343/comment/4f467d33_437d5db4 : PS3, Line 1: GPL-2.0-only
Should be CC-PDDC, refer to commit cf4722d317 (src/mb: Update unlicensable files with the CC-PDDC SP […]
Makes sense, thanks.
File src/mainboard/lenovo/thinkcentre_m710s/acpi/superio.asl:
https://review.coreboot.org/c/coreboot/+/80343/comment/becdd1c7_77a10b5c : PS3, Line 1: GPL-2.0-onl
CC-PDDC
Done