Change in coreboot[master]: src/soc/intel/commmon/itss: Add support to get interrupt table for PC...
build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34089 )
Change subject: src/soc/intel/commmon/itss: Add support to get interrupt table for PCI devices ......................................................................
Patch Set 6:
(5 comments)
https://review.coreboot.org/c/coreboot/+/34089/6/src/soc/intel/common/block/... File src/soc/intel/common/block/include/intelblocks/irq.h:
https://review.coreboot.org/c/coreboot/+/34089/6/src/soc/intel/common/block/... PS6, Line 37: const int * get_soc_irq_devices(size_t *size); "foo * bar" should be "foo *bar"
https://review.coreboot.org/c/coreboot/+/34089/6/src/soc/intel/common/block/... File src/soc/intel/common/block/itss/irq.c:
https://review.coreboot.org/c/coreboot/+/34089/6/src/soc/intel/common/block/... PS6, Line 95: if(!devlist) space required before the open parenthesis '('
https://review.coreboot.org/c/coreboot/+/34089/6/src/soc/intel/common/block/... PS6, Line 97: for(int i=0; i < size; i++) { spaces required around that '=' (ctx:VxV)
https://review.coreboot.org/c/coreboot/+/34089/6/src/soc/intel/common/block/... PS6, Line 97: for(int i=0; i < size; i++) { space required before the open parenthesis '('
https://review.coreboot.org/c/coreboot/+/34089/6/src/soc/intel/common/block/... PS6, Line 135: if(!irq_config) space required before the open parenthesis '('
-
build bot (Jenkins) (Code Review)