Attention is currently required from: Angel Pons, Cliff Huang, Felix Held, Felix Singer, Lance Zhao, Naresh Solanki, Patrick Rudolph, Tim Wawrzynczak.
Arthur Heymans has posted comments on this change by Naresh Solanki. ( https://review.coreboot.org/c/coreboot/+/79404?usp=email )
Change subject: acpi: Add IORT helper functions
......................................................................
Patch Set 6:
(4 comments)
File src/acpi/acpi_iort.c:
https://review.coreboot.org/c/coreboot/+/79404/comment/f348810c_23be7915?usp... :
PS6, Line 7: acpi_iort_node_t **its,
Does it make sense to return this? There are 0 mappings?
https://review.coreboot.org/c/coreboot/+/79404/comment/8e009e7a_247a250f?usp... :
PS6, Line 13: *its = (acpi_iort_node_t *)current;
it might be a bit easier to read to have a local variable too:
acpi_iort_node_t *its_entry = (acpi_iort_node_t *)current;
I suspect the compiler generates the same code. (*its)->xxx becomes its_enry->
https://review.coreboot.org/c/coreboot/+/79404/comment/793f5e6b_591da878?usp... :
PS6, Line 46: (*smmu_v3)->mapping_count = 0;
already done in memset.
https://review.coreboot.org/c/coreboot/+/79404/comment/e3349eb3_36375439?usp... :
PS6, Line 82: memset(nc_node_data->device_name, 0, 16);
: strncpy(nc_node_data->device_name, device_name, device_name_len);
:
: current += device_name_len + 2;
: current = ALIGN_UP(current, 4);
Should this not be a null terminated string?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/79404?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I7feaf306b5eea21bfc9a2e2a1a2c3ddc3c683c0b
Gerrit-Change-Number: 79404
Gerrit-PatchSet: 6
Gerrit-Owner: Naresh Solanki
naresh.solanki@9elements.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Cliff Huang
cliff.huang@intel.com
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Lance Zhao
lance.zhao@gmail.com
Gerrit-Reviewer: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Reviewer: Tim Wawrzynczak
inforichland@gmail.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Felix Singer
service+coreboot-gerrit@felixsinger.de
Gerrit-CC: Lean Sheng Tan
sheng.tan@9elements.com
Gerrit-Attention: Felix Singer
service+coreboot-gerrit@felixsinger.de
Gerrit-Attention: Lance Zhao
lance.zhao@gmail.com
Gerrit-Attention: Cliff Huang
cliff.huang@intel.com
Gerrit-Attention: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Attention: Tim Wawrzynczak
inforichland@gmail.com
Gerrit-Attention: Angel Pons
th3fanbus@gmail.com
Gerrit-Attention: Naresh Solanki
naresh.solanki@9elements.com
Gerrit-Attention: Felix Held
felix-coreboot@felixheld.de
Gerrit-Comment-Date: Tue, 24 Sep 2024 16:25:41 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No