Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/25437 )
Change subject: FSP 2.0: Add fsp_relax_security
......................................................................
Patch Set 22:
(1 comment)
https://review.coreboot.org/c/coreboot/+/25437/22/src/drivers/intel/fsp2_0/n...
File src/drivers/intel/fsp2_0/notify.c:
https://review.coreboot.org/c/coreboot/+/25437/22/src/drivers/intel/fsp2_0/n...
PS22, Line 58: __weak bool should_fsp_relax_security(void)
In case this goes in, please use a more specific name. Technically it's
should_fsp_skip_readytoboot_and_endoffirmware()
For Denverton, this might be about locks only, but for other platforms
it seems to be much more. For instance, when I tried something like this
with KabyLakeFSP, some controller stopped working (xHCI or AHCI, IIRC).
--
To view, visit
https://review.coreboot.org/c/coreboot/+/25437
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I972e7387c2612ee0053df21afb55b0b264961174
Gerrit-Change-Number: 25437
Gerrit-PatchSet: 22
Gerrit-Owner: Julien Viard de Galbert
coreboot-review-ju@vdg.name
Gerrit-Reviewer: Andrey Petrov
andrey.petrov@gmail.com
Gerrit-Reviewer: David Guckian
d.guckian20@gmail.com
Gerrit-Reviewer: Julien Viard de Galbert
coreboot-review-ju@vdg.name
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Reviewer: Vanessa Eusebio
vanessa.f.eusebio@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Aaron Durbin
adurbin@chromium.org
Gerrit-CC: Angel Pons
th3fanbus@gmail.com
Gerrit-CC: Lijian Zhao
lijian.zhao@intel.com
Gerrit-CC: Michael Niewöhner
foss@mniewoehner.de
Gerrit-CC: Nico Huber
nico.h@gmx.de
Gerrit-Comment-Date: Thu, 12 Nov 2020 22:21:53 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment